From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
QEMU Developers <qemu-devel@nongnu.org>,
KVM list <kvm@vger.kernel.org>,
linux-s390@vger.kernel.org, adrian@parity.io
Cc: "Woodhouse, David" <dwmw@amazon.co.uk>,
"Catangiu, Adrian Costin" <acatan@amazon.com>,
graf@amazon.com, Colm MacCarthaigh <colmmacc@amazon.com>,
"Singh, Balbir" <sblbir@amazon.com>,
"Weiss, Radu" <raduweis@amazon.com>, Jann Horn <jannh@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Igor Mammedov <imammedo@redhat.com>,
ehabkost@redhat.com, ben@skyportsystems.com,
"Michael S. Tsirkin" <mst@redhat.com>,
lersek@redhat.com
Subject: Re: [PATCH RFC v1 0/2] VM fork detection for RNG
Date: Wed, 23 Feb 2022 17:19:45 +0100 [thread overview]
Message-ID: <CAHmME9o9-eBCcjJMrJSdr23VfUEfvx12e4qRdtE5Sv3+Qcf-Bg@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9ogH_mx724n_deFfva7-xPCmma1-=2Mv0JdnZ-fC4JCjg@mail.gmail.com>
On Wed, Feb 23, 2022 at 5:08 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> On Wed, Feb 23, 2022 at 2:12 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> > second patch is the reason this is just an RFC: it's a cleanup of the
> > ACPI driver from last year, and I don't really have much experience
> > writing, testing, debugging, or maintaining these types of drivers.
> > Ideally this thread would yield somebody saying, "I see the intent of
> > this; I'm happy to take over ownership of this part." That way, I can
> > focus on the RNG part, and whoever steps up for the paravirt ACPI part
> > can focus on that.
>
> I actually managed to test this in QEMU, and it seems to work quite well. Steps:
>
> $ qemu-system-x86_64 ... -device vmgenid,guid=auto -monitor stdio
> (qemu) savevm blah
> (qemu) quit
> $ qemu-system-x86_64 ... -device vmgenid,guid=auto -monitor stdio
> (qemu) loadvm blah
>
> Doing this successfully triggers the function to reinitialize the RNG
> with the new GUID. (It appears there's a bug in QEMU which prevents
> the GUID from being reinitialized when running `loadvm` without
> quitting first; I suppose this should be discussed with QEMU
> upstream.)
>
> So that's very positive. But I would appreciate hearing from some
> ACPI/Virt/Amazon people about this.
Because something something picture thousand words something, here's a
gif to see this working as expected:
https://data.zx2c4.com/vmgenid-appears-to-work.gif
Jason
next prev parent reply other threads:[~2022-02-23 16:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:12 [PATCH RFC v1 0/2] VM fork detection for RNG Jason A. Donenfeld
2022-02-23 13:12 ` [PATCH RFC v1 1/2] random: add mechanism for VM forks to reinitialize crng Jason A. Donenfeld
2022-02-23 23:16 ` Eric Biggers
2022-02-24 0:54 ` Jason A. Donenfeld
2022-02-24 1:27 ` Eric Biggers
2022-02-24 11:15 ` Jason A. Donenfeld
2022-02-23 13:12 ` [PATCH RFC v1 2/2] drivers/virt: add vmgenid driver for reinitializing RNG Jason A. Donenfeld
2022-02-23 16:36 ` Jason A. Donenfeld
2022-02-23 16:08 ` [PATCH RFC v1 0/2] VM fork detection for RNG Jason A. Donenfeld
2022-02-23 16:19 ` Jason A. Donenfeld [this message]
[not found] ` <2653b6c7-a851-7a48-f1f8-3bde742a0c9f@redhat.com>
2022-02-24 10:43 ` Jason A. Donenfeld
2022-02-24 10:55 ` Daniel P. Berrangé
2022-02-24 10:57 ` Jason A. Donenfeld
2022-02-25 10:40 ` Michael S. Tsirkin
2022-02-24 8:53 ` Alexander Graf
2022-02-24 10:43 ` Daniel P. Berrangé
2022-02-24 11:35 ` Alexander Graf
2022-02-24 10:53 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9o9-eBCcjJMrJSdr23VfUEfvx12e4qRdtE5Sv3+Qcf-Bg@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=acatan@amazon.com \
--cc=adrian@parity.io \
--cc=ben@skyportsystems.com \
--cc=colmmacc@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=ehabkost@redhat.com \
--cc=graf@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=imammedo@redhat.com \
--cc=jannh@google.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raduweis@amazon.com \
--cc=sblbir@amazon.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).