linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: viro@zeniv.linux.org.uk
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] splice: allow direct splicing with chardevs
Date: Thu, 26 May 2022 23:19:46 +0200	[thread overview]
Message-ID: <CAHmME9pSZYZSz3YLRK7onO0E6zq9_B1GNwoTOkEQy_kws200Fw@mail.gmail.com> (raw)
In-Reply-To: <938111ca-d3c7-9888-24f8-0017a989002b@kernel.dk>

Hey Al,

On 5/20/22, Jens Axboe <axboe@kernel.dk> wrote:
> On 5/20/22 3:57 AM, Jason A. Donenfeld wrote:
>> The original direct splicing mechanism from Jens required the input to
>> be a regular file because it was avoiding the special socket case. It
>> also recognized blkdevs as being close enough to a regular file. But it
>> forgot about chardevs, which behave the same way and work fine here.
>>
>> This commit adds the missing S_ISCHR condition so that chardevs such as
>> /dev/urandom can be directly spliced without strangely returning
>> -EINVAL.
>
> Should be fine to turn this on for char devices:
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
>

Was wondering if this would make 5.19. That'd be nice, as it's the
release in which we switch to read_iter().

Jason

  reply	other threads:[~2022-05-26 21:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20  9:57 [PATCH] splice: allow direct splicing with chardevs Jason A. Donenfeld
2022-05-20 14:34 ` Jens Axboe
2022-05-26 21:19   ` Jason A. Donenfeld [this message]
2022-06-08 12:49     ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9pSZYZSz3YLRK7onO0E6zq9_B1GNwoTOkEQy_kws200Fw@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).