From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Mathieu Malaterre <malat@debian.org>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs
Date: Wed, 13 Mar 2019 14:34:23 -0600 [thread overview]
Message-ID: <CAHmME9psZb0XoKHjGP23TYsSwMU2G-WN81RKg8AvyY-rZLvy4g@mail.gmail.com> (raw)
In-Reply-To: <20190313202429.20797-1-malat@debian.org>
Conceptually this seems pretty reasonable. Though, style-wise, perhaps
you might want to put those breaks on the next line too, i.e. s/;
break;/;\n\t\tbreak;/?
next prev parent reply other threads:[~2019-03-13 20:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 20:19 [PATCH] lib/siphash.c:: annotate implicit fall throughs Mathieu Malaterre
2019-01-14 21:04 ` Gustavo A. R. Silva
2019-03-13 20:24 ` [PATCH v2] lib/siphash.c: " Mathieu Malaterre
2019-03-13 20:34 ` Jason A. Donenfeld [this message]
2019-03-13 20:44 ` Gustavo A. R. Silva
2019-03-13 20:52 ` Mathieu Malaterre
2019-03-13 21:12 ` [PATCH v3] " Mathieu Malaterre
2019-03-14 1:50 ` Joe Perches
2019-03-14 7:01 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9psZb0XoKHjGP23TYsSwMU2G-WN81RKg8AvyY-rZLvy4g@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).