From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C03DC43334 for ; Tue, 19 Jul 2022 13:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238949AbiGSNbf (ORCPT ); Tue, 19 Jul 2022 09:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239350AbiGSNbG (ORCPT ); Tue, 19 Jul 2022 09:31:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E26198AEEB; Tue, 19 Jul 2022 05:46:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 264DC61740; Tue, 19 Jul 2022 12:46:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10499C341CA; Tue, 19 Jul 2022 12:46:47 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="orkHbPvm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1658234804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0M1RG9G8cO37nst2CD7DZ89TkqR9zkT7SUAp4B3bFOM=; b=orkHbPvmh6q5POuNqNQH1spr0aScRPGyZ7oXanlg68fil/7h/19PejEl4f1pwSHLoAmcIV V2f6KVxx+ALuprKlhga/EvwF53pj8Mk52asCsYsis1Jj1IVNESFZl34vlmgnxJyLUhHuep 27JHgQYYlRkZPwkVGBqhthNjepG1c3o= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 4ee87988 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 19 Jul 2022 12:46:44 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id l3so8850612qkl.3; Tue, 19 Jul 2022 05:46:43 -0700 (PDT) X-Gm-Message-State: AJIora855FplDa1R37UbKhwepcGLyLszeObJK2tMQx5P0fTW0pKqOikd +mZGnWRRsF8a9cDTvpS5r114tk4FfztMFFGYyhw= X-Google-Smtp-Source: AGRyM1t2xq+LcMrIzmoeK42JgLdc9jD9mAg3j5fHR2WcBcobwuU+HIL3Q4G9gniTA5GYzRlJybQa0yDZOX953fr+g+E= X-Received: by 2002:a05:620a:4552:b0:6b5:fc9f:e7a7 with SMTP id u18-20020a05620a455200b006b5fc9fe7a7mr2138601qkp.65.1658234802386; Tue, 19 Jul 2022 05:46:42 -0700 (PDT) MIME-Version: 1.0 References: <20220717200356.75060-1-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Tue, 19 Jul 2022 14:46:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] random: handle archrandom in plural words To: Mark Rutland Cc: LKML , linux-arm-kernel , PowerPC , linux-s390@vger.kernel.org, X86 ML , Will Deacon , Michael Ellerman , Alexander Gordeev , Thomas Gleixner , "H . Peter Anvin" , Catalin Marinas , Borislav Petkov , Heiko Carstens , Johannes Berg , Harald Freudenberger Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Tue, Jul 19, 2022 at 2:42 PM Mark Rutland wrote: > > -static inline bool __must_check arch_get_random_long(unsigned long *v) > > +static inline size_t __must_check arch_get_random_words(unsigned long *v, size_t words) > > As others have suggested, could we please s/words/longs/? That's a smaller > change from the existing name, and avoids amibugity were "word" has an > architecture-specific meaning. e.g. the ARM ARM (ARM DDI 0487G.b) defines: At first I had thought, "erm, I like 'words'" but decided to wait it out, and now it's two people with the same probably good objection to 'words', so I'll send a v+1 with 'longs' instead. Thanks for your feedback. Patch incoming. > FWIW, other than the naming nits, the arm64 bits look fine to me. Oh good. Can you send an Acked-by for v+1? Coming up shortly. Jason