From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758413AbcLPUny (ORCPT ); Fri, 16 Dec 2016 15:43:54 -0500 Received: from frisell.zx2c4.com ([192.95.5.64]:55223 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756119AbcLPUnp (ORCPT ); Fri, 16 Dec 2016 15:43:45 -0500 MIME-Version: 1.0 From: "Jason A. Donenfeld" Date: Fri, 16 Dec 2016 21:43:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF To: George Spelvin Cc: Tom Herbert , Andi Kleen , David Miller , David Laight , "Daniel J . Bernstein" , Eric Biggers , Hannes Frederic Sowa , Jean-Philippe Aumasson , kernel-hardening@lists.openwall.com, Linux Crypto Mailing List , LKML , Andy Lutomirski , Netdev , Linus Torvalds , "Theodore Ts'o" , Vegard Nossum Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 9:41 PM, George Spelvin wrote: > What are you testing on? And what input size? And does "33% improvement" > mean 4/3 the rate and 3/4 the time? Or 2/3 the time and 3/2 the rate? How that I've published my hsiphash implementation to my tree, it should be possible to conduct the tests back to back with nearly identical implementation strategies, to remove a potential source of error.