linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
	Timon Baetz <timon.baetz@protonmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional
Date: Mon, 8 Mar 2021 18:10:11 +0200	[thread overview]
Message-ID: <CAHp75Vc0dgD0m12BRzjv=Ldn0hxxY3geR8HswgwoMeYBz_fVFA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcMAWFCOFEXizuOvDZs=qDSYndH=Y9RhgLdjb9547Op+Q@mail.gmail.com>

On Mon, Mar 8, 2021 at 6:06 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> > -       depends on EXTCON || !EXTCON
>
> I stumbled over this.
> What is the point of having this line at all?
> What magic trick does it serve for?

Okay, it seems I can answer my question: it requires extcon to be
built-in when the driver is built-in. I often saw similar written
slightly differently.



-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-03-08 16:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 15:29 [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional Arnd Bergmann
2021-03-08 15:33 ` Krzysztof Kozlowski
2021-03-08 16:02   ` Arnd Bergmann
2021-03-08 16:11     ` Krzysztof Kozlowski
2021-03-09 10:11       ` Chanwoo Choi
2021-03-08 15:50 ` Matti Vaittinen
2021-03-08 16:07   ` Arnd Bergmann
2021-03-08 16:06 ` Andy Shevchenko
2021-03-08 16:10   ` Andy Shevchenko [this message]
2021-03-08 16:31   ` Vaittinen, Matti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vc0dgD0m12BRzjv=Ldn0hxxY3geR8HswgwoMeYBz_fVFA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=sre@kernel.org \
    --cc=timon.baetz@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).