From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B1CC433E3 for ; Sat, 22 Aug 2020 09:23:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09CD7207C3 for ; Sat, 22 Aug 2020 09:23:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BjRC2XO6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbgHVJXa (ORCPT ); Sat, 22 Aug 2020 05:23:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbgHVJXa (ORCPT ); Sat, 22 Aug 2020 05:23:30 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18DC2C061573; Sat, 22 Aug 2020 02:23:30 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id v15so2134841pgh.6; Sat, 22 Aug 2020 02:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aI39wUQrT4gwVKkfiPc/6BrYsBsFxtTiYiQuKGUyQNc=; b=BjRC2XO6ziRv5s9rs7O7otCwVIpQS+qXELx0bfeHcgi7yZMg4ZDjYCKCzeE3cSrn7J h4rt+xfTU7u3rEtLqLTGv/nx/hmTQOJM5YZIJH2l2TP+6Z9sWo6O0X+LDYXWfDrGHZFJ Aha7B53M6BI+GRJorY7VSNxeD7kQ82nnZeclcZICDoVEFKn1GwaFbFkmNZvRVFMWjcLk ygWjIEK/hsHVLQbtAM+aq9UkdYx1spA51nTnAHVL+b+nu1B6VMIIY2vW6F6KkIXUIwfb zzBeU9UXeVKXTAmxcK+hVjZq4b7zZxDNIi/Q55A/2LmnGUHt45k1x0ry0jfeNHoWkAZA RlQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aI39wUQrT4gwVKkfiPc/6BrYsBsFxtTiYiQuKGUyQNc=; b=CgHdDhIh1TS0kOaQCWSKo5f9MMBiPgtCe34Ot5b9FLpy85E60P42c3Ho1ivcEvN91D 1VpE3vHAoSGx0dZSsBBK93Ql6tOFuwkHoCSqpyNBJwFhCGgeg5W6T5gYJfoQSKYLBLQQ IUynCCG1hnGubSITmGiqqfD9ckIVHOir9PqexS+rYPNHv/UBN9P8Jj8A996B4Wy36oS5 VUfqcfOn/K75uspeAo+z07KFcHeclMI0SpP0/QEQpu9noidie69ZttrQr6TtSkFsiX+9 iILXAviE1S9UYRBa42Uq+HCt6YCjqSftcpwzlRSOwnbsyDXg2fa6nvfkqfzgY4ncTv5r UKBA== X-Gm-Message-State: AOAM530GjCK3lEzGRl/2h0i12UvH0QXuoh/M21OwH0Eax+WbibpkuHpb mW8Gb9htfwPYzl8BIrQ5U4nTBETIynx/wJRmXlH3svQkzGKsfw== X-Google-Smtp-Source: ABdhPJz4qAwL/hficWhPP7/Q7Cn9/sFEW/U3BO4PJc8qZ0j+3vpx+hdgMhcqDNRluDgzEX2ahyveuiGTLzTTJBe0Qco= X-Received: by 2002:a62:c319:: with SMTP id v25mr5537864pfg.130.1598088209565; Sat, 22 Aug 2020 02:23:29 -0700 (PDT) MIME-Version: 1.0 References: <20200821105618.GO1891694@smile.fi.intel.com> In-Reply-To: From: Andy Shevchenko Date: Sat, 22 Aug 2020 12:23:12 +0300 Message-ID: Subject: Re: [PATCH v9 2/2] Add PWM fan controller driver for LGM SoC To: "Tanwar, Rahul" Cc: Andy Shevchenko , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-pwm@vger.kernel.org, Lee Jones , Thierry Reding , Philipp Zabel , Rob Herring , Linux Kernel Mailing List , devicetree , songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 22, 2020 at 8:25 AM Tanwar, Rahul wrote: > On 21/8/2020 6:56 pm, Andy Shevchenko wrote: > > On Fri, Aug 21, 2020 at 05:32:11PM +0800, Rahul Tanwar wrote: ... > >> +#include > >> +#include > >> +#include > >> +#include > > We haven't settle this yet... > > I investigated more about it. I was getting build error because we were > relying on of_device.h for including platform_device.h. You are right that > we are not using anything from of_device.h. So i removed of_device.h from > driver and added include & build is ok. > > Regarding mod_devicetable.h header, it gets included indirectly from > which includes of.h which includes mod_devicetable.h. So i > think no point including it again in the driver. Ideally you should include all headers you have direct users of. mod_devicetable.h is exactly one and I doubt the pwm.h should include it, but it's another story. There are, of course, some cases when not all required because there is a guarantee that upper one includes lower one. For example, if you use bitops.h there is no need to include bits.h. > >> +#include > >> +#include > >> +#include -- With Best Regards, Andy Shevchenko