From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754237AbdCOWnv (ORCPT ); Wed, 15 Mar 2017 18:43:51 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35312 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753043AbdCOWnq (ORCPT ); Wed, 15 Mar 2017 18:43:46 -0400 MIME-Version: 1.0 In-Reply-To: <1bfce335-7a66-9905-b196-47366bf73d37@osg.samsung.com> References: <20170314151638.23132-1-javier@osg.samsung.com> <20170314151638.23132-5-javier@osg.samsung.com> <8e233f15-4f91-b495-5270-5a7f982b31be@osg.samsung.com> <20170315075835.GA1438@katana> <1bfce335-7a66-9905-b196-47366bf73d37@osg.samsung.com> From: Andy Shevchenko Date: Thu, 16 Mar 2017 00:43:44 +0200 Message-ID: Subject: Re: [PATCH 4/4] eeprom: at24: Add OF device ID table To: Javier Martinez Canillas Cc: Wolfram Sang , "linux-kernel@vger.kernel.org" , linux-i2c@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 15, 2017 at 1:39 PM, Javier Martinez Canillas wrote: > Hello Andy, > > On 03/15/2017 08:21 AM, Andy Shevchenko wrote: >> On Wed, Mar 15, 2017 at 12:58 PM, Javier Martinez Canillas >> wrote: >>> On 03/15/2017 04:58 AM, Wolfram Sang wrote: >> >>> Unfortunately some maintainers do and don't accept patches adding I2C tables >>> only to have module autoloading working so I still think it should be fixed. >> >> Wait, how does it work for now?! > It only works if you have an I2C device ID table, but that may not be the case > for DT-only drivers that could only have an OF device ID table. In the latter > case module autoload won't work. OK. >> Sounds for me you are trying to solve non-existing issue. > It's an existing issue. You _must_ have an I2C device ID table if you want to > autload a device driver which is superfluous for DT-only drivers. Okay, can you scope only affected drivers then? Looking to spread patches from you over all drivers I dunno they are all affected right now. P.S. Personally I agree with maintainers who do *not* apply this. Sorry. -- With Best Regards, Andy Shevchenko