From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] x86/mtrr: Convert to use match_string() helper
Date: Sun, 13 May 2018 23:34:20 +0300 [thread overview]
Message-ID: <CAHp75Vc1_+9+vLxJLA6eCtcvcdiqekO0m_jnWH5DZsPfugJXRg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1805132119510.1582@nanos.tec.linutronix.de>
On Sun, May 13, 2018 at 10:23 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 4 May 2018, Andy Shevchenko wrote:
>
>> The new helper returns index of the matching string in an array.
>
> new helper? match_string() is in tree for 2 years.
Old template.
>> We are going to use it here.
>
> Are we going to use it ? When?
>
> "Replace the open coded array lookup." or something like that would be more
> appropriate.
Will change this.
Thanks for review!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-05-13 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 21:12 [PATCH v1] x86/mtrr: Convert to use match_string() helper Andy Shevchenko
2018-05-13 19:23 ` Thomas Gleixner
2018-05-13 20:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc1_+9+vLxJLA6eCtcvcdiqekO0m_jnWH5DZsPfugJXRg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).