From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Joel Becker" <jlbec@evilplan.org>,
"Christoph Hellwig" <hch@lst.de>, "Shuah Khan" <shuah@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Kent Gibson" <warthog618@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags
Date: Mon, 15 Mar 2021 18:36:54 +0200 [thread overview]
Message-ID: <CAHp75Vc3Fr3Ysv0p7-W1Bf5y1Em17psZ=eCgVNewdVF=AjPm-g@mail.gmail.com> (raw)
In-Reply-To: <6bc83972093a4be4ad163069a437ec25@AcuMS.aculab.com>
On Mon, Mar 15, 2021 at 5:33 PM David Laight <David.Laight@aculab.com> wrote:
> From: Bartosz Golaszewski
> > Sent: 15 March 2021 09:14
> >
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > For better readability and maintenance: use the (1UL << bit) for flag
> > definitions.
>
> If the values ever get printed in hex the hex definitions are
> actually more useful.
Huh?!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-15 16:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 9:13 [PATCH v5 00/11] gpio: implement the configfs testing module Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 01/11] configfs: increase the item name length Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags Bartosz Golaszewski
2021-03-15 15:31 ` David Laight
2021-03-15 16:36 ` Andy Shevchenko [this message]
2021-03-15 9:13 ` [PATCH v5 03/11] configfs: implement committable items Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 04/11] samples: configfs: add a committable group Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 05/11] lib: bitmap: remove the 'extern' keyword from function declarations Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 06/11] lib: bitmap: order includes alphabetically Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc() Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 08/11] gpio: sim: new testing module Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 09/11] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 10/11] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-03-15 9:14 ` [PATCH v5 11/11] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
2021-03-22 14:32 ` [PATCH v5 00/11] gpio: implement the configfs testing module Bartosz Golaszewski
2021-03-23 16:17 ` Andy Shevchenko
2021-03-25 9:29 ` Linus Walleij
2021-03-26 14:00 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vc3Fr3Ysv0p7-W1Bf5y1Em17psZ=eCgVNewdVF=AjPm-g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=David.Laight@aculab.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).