From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753620AbdARTIs (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Jan 2017 14:08:48 -0500
Received: from mail-yw0-f194.google.com ([209.85.161.194]:34023 "EHLO
        mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752046AbdARTIp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Jan 2017 14:08:45 -0500
MIME-Version: 1.0
In-Reply-To: <20170117071714.21594-1-kernel@kempniu.pl>
References: <20170116132204.6421-1-kernel@kempniu.pl> <20170117071714.21594-1-kernel@kempniu.pl>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 18 Jan 2017 21:06:00 +0200
Message-ID: <CAHp75Vc3LnFGPjMt8uYQeqHWPqMM-rFzsdLA94C5bJQgq++K6w@mail.gmail.com>
Subject: Re: [PATCH v2 6+/6] platform/x86: dell-wmi-led: fix coding style issues
To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= <kernel@kempniu.pl>
Cc: Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>,
        Darren Hart <dvhart@infradead.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Anthony Wong <anthony.wong@canonical.com>, linux-leds@vger.kernel.org,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0IJ9mN4000667

On Tue, Jan 17, 2017 at 9:17 AM, Michał Kępień <kernel@kempniu.pl> wrote:
> Fix coding style issues in dell-wmi-led which checkpatch complains about
> to make sure the module gets a clean start in the x86 platform driver
> subsystem.

> +       status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 1, 1, &input, &output);
>

You may remove extra line.

>         if (ACPI_FAILURE(status))
>                 return status;

> -       if (0 == on_eighths)
> +       if (on_eighths == 0)
>                 on_eighths = 1;
>         if (on_eighths > 255)
>                 on_eighths = 255;

> -       if (0 == off_eighths)
> +       if (off_eighths == 0)
>                 off_eighths = 1;
>         if (off_eighths > 255)
>                 off_eighths = 255;

Obviously they both are custom clamp{_t}().

-- 
With Best Regards,
Andy Shevchenko