From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D16C1B0E3 for ; Mon, 14 Dec 2020 11:21:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3108F22B47 for ; Mon, 14 Dec 2020 11:21:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730276AbgLNLVS (ORCPT ); Mon, 14 Dec 2020 06:21:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437219AbgLNLUu (ORCPT ); Mon, 14 Dec 2020 06:20:50 -0500 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1076DC0613CF; Mon, 14 Dec 2020 03:20:10 -0800 (PST) Received: by mail-pj1-x1043.google.com with SMTP id z12so6112108pjn.1; Mon, 14 Dec 2020 03:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ETJkm2h9mUdQRDtcG4X/2MD3yrQCIlxA3Hfl870jwj4=; b=r25mGmNkMaVymoukJdYxFlGJGfK3XkU1Ny6frMPmg1Fdb4iaEVZVO5QJxKuLBsNJCd 9XIjrmInI0sKFHvqhJeTasbCPeKoST0dYXVhh4kAwaiDpK3laTHnDD+5gjnjupU8Mzwe JLq3IWBkN+fpgnsUsbkaGyuzOcZhMzCkaWWU0/f/zXhUnxzXpa89XE5mmqtgUXmywH2O 1ElETGTCZHt/SjBNRVeHXfxYwdu5YNvQMXijPywj125EwbqRD7balLvykrWwlfNoQg6j sQyhCi1yW6GLYyDZA2T4UUiKctuaj0MJDVQL9YFMTS/kBY2AQQGLnYxqG9bbWAIj9TUP KShg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ETJkm2h9mUdQRDtcG4X/2MD3yrQCIlxA3Hfl870jwj4=; b=m4EH+dIxDKEWHj/OugtKAY/Z4bfqdtDUHusT6fVYTtMaJZm2TTu6ECsz4csH9x2ff/ B4k/+kw7fxl7KsWwL83QjNsil1ayHDtRZMwfXM4g80y1+z6aVQtcMSiyot1sWQ1fDYBp vkcCcMquiRUtvUu8VjNyBmf+AWKxga+z+8IMtogATNPNiFmiWdPcfmHf9b2rLfeQUDZM h3k5lRT4iK/1athnIv4sqP8GzyXKllvoTO3t1ZoEaO5sIr7aEwkEzu4qEAJsNEGjmdv0 vz3oKYrwyPh619W2BQFYSqZDSUBp7noMR9p0Qxn9oq/ISTfhYLXBi0jidPU+bM2sq4CB Ga0Q== X-Gm-Message-State: AOAM532V3EMtO6zpD+iXij95fSxEli161w13K7lwo6O8W3e0D0Z/A7t+ otxXp8+WkYT5u1jGgDxw9dT6nz6FkrgRRhTKJyo= X-Google-Smtp-Source: ABdhPJxx632u2IOxtU3Khq37YXRxCyhybqvc7sZw19fW3k6MMlCDyqHRfIJROCTqqmNg6nOj9Dnnq1qLiQh0tpkR8Rw= X-Received: by 2002:a17:90b:a17:: with SMTP id gg23mr25511515pjb.129.1607944809447; Mon, 14 Dec 2020 03:20:09 -0800 (PST) MIME-Version: 1.0 References: <20201211190335.16501-1-rdunlap@infradead.org> <3d5a5c8f-4bb1-6205-ae76-354473d59a18@infradead.org> In-Reply-To: <3d5a5c8f-4bb1-6205-ae76-354473d59a18@infradead.org> From: Andy Shevchenko Date: Mon, 14 Dec 2020 13:19:52 +0200 Message-ID: Subject: Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings To: Randy Dunlap , Arnd Bergmann Cc: Linux Kernel Mailing List , Maximilian Luz , Hans de Goede , Platform Driver Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2020 at 2:53 AM Randy Dunlap wrote: > On 12/12/20 11:07 AM, Andy Shevchenko wrote: > > On Sat, Dec 12, 2020 at 7:05 PM Randy Dunlap wrote: ... > > Here [1] is the rationale behind annotation vs. ifdeffery. > > > > [1]: https://lore.kernel.org/patchwork/patch/732981/ > > > Thanks for the link. I'll send a v2. > > Could we add that to the Linux BKP (Best Known Practices) > document? Perhaps. The author of that is Arnd, maybe he has something to add. -- With Best Regards, Andy Shevchenko