Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Yicong Yang <yangyicong@hisilicon.com>,
	Wei Xu <xuwei5@hisilicon.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI
Date: Mon, 19 Apr 2021 17:27:47 +0300	[thread overview]
Message-ID: <CAHp75Vc5yGALSh2pxt6z_6bsyFweuu+vPH6dFKQtBMzXM-dY6Q@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVwWLpS-N2fvihLcJ9RsAppzRMd5ZQhra-sz6EFavhy2g@mail.gmail.com>

On Mon, Apr 19, 2021 at 5:18 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Apr 19, 2021 at 4:14 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Apr 19, 2021 at 4:58 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Mon, Apr 19, 2021 at 4:54 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > > > > In any case it's not true. We have the platform drivers w/o legacy
> > > > > users that are not dependent on OF.
> > > >
> > > > Example? ;-)
> > >
> > > i2c-owl.c
> >
> > In case you want more
> > sound/sparc/amd7930.c
>
> SND_SUN_AMD7930 depends on SND_SPARC && SBUS
> SND_SPARC depends on SPARC
> SPARC selects OF
>
> Hence, SND_SUN_AMD7930 depends on OF.

Exactly my point. Read back what I wrote.

TL;DR: It's *fine* to have _indirect_ dependency like this.

-- 
With Best Regards,
Andy Shevchenko