From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Yu Tu <yu.tu@amlogic.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-amlogic <linux-amlogic@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH V2 1/2] tty: serial: meson: Add a 12MHz internal clock rate to calculate baud rate in order to meet the baud rate requirements of special BT modules
Date: Tue, 19 Apr 2022 11:21:32 +0300 [thread overview]
Message-ID: <CAHp75Vc87oTmJ6zVeY2mGbP8Jx_SSDtp39Uq4YhWerDUX9RdQQ@mail.gmail.com> (raw)
In-Reply-To: <9af92c78-73a7-d524-182c-3ebffa69b08a@kernel.org>
On Tue, Apr 19, 2022 at 10:38 AM Jiri Slaby <jirislaby@kernel.org> wrote:
> On 19. 04. 22, 9:29, Yu Tu wrote:
> > On 2022/4/18 20:09, Andy Shevchenko wrote:
> >> On Mon, Apr 18, 2022 at 8:50 AM Yu Tu <yu.tu@amlogic.com> wrote:
...
> >>> +struct meson_uart_data {
> >>> + bool has_xtal_div2;
> >>
> >> I would prefer to see this as an unsigned int and with a less
> >> particular name, e.g. xtal_div would suffice.
> > I don't have a problem with your suggestion.Let's see What Neil has to say.
>
> Actually why uint provided it's a boolean value? Or do you mean to store
> the divisor directly in this member, Andy?
Yes I was thinking to provide the value and then always provide the
private data. In such cases we don't need an additional condition.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-19 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 5:32 [PATCH V2 0/2] Add q 12MHz internal clock rate to calculate Yu Tu
2022-04-18 5:32 ` [PATCH V2 1/2] tty: serial: meson: Add a 12MHz internal clock rate to calculate baud rate in order to meet the baud rate requirements of special BT modules Yu Tu
2022-04-18 12:09 ` Andy Shevchenko
2022-04-19 7:29 ` Yu Tu
2022-04-19 7:38 ` Jiri Slaby
2022-04-19 8:21 ` Andy Shevchenko [this message]
2022-04-21 8:44 ` Neil Armstrong
2022-04-19 8:43 ` Yu Tu
2022-04-21 8:46 ` Neil Armstrong
2022-04-21 9:46 ` Yu Tu
2022-04-18 5:32 ` [PATCH V2 2/2] tty: serial: meson: Added S4 SOC compatibility Yu Tu
2022-04-21 8:49 ` Neil Armstrong
2022-04-21 9:47 ` Yu Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc87oTmJ6zVeY2mGbP8Jx_SSDtp39Uq4YhWerDUX9RdQQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=yu.tu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).