From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Corentin Chary <corentin.chary@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] platform/x86: samsung-laptop: set debugfs blobs to read only
Date: Tue, 4 May 2021 20:38:24 +0300 [thread overview]
Message-ID: <CAHp75Vc8OGDB0=ta_GLg3Bjv5NK32dMuuaPTX-ETXRDHtRpxnA@mail.gmail.com> (raw)
In-Reply-To: <20210504170030.58447-2-wsa+renesas@sang-engineering.com>
On Tue, May 4, 2021 at 8:18 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Those blobs can only be read. So, don't confuse users with 'writable'
> flags.
Not sure if this should be the second patch in the series (sounds like
a potential fix).
Either way
Reviewed-by: Andy Shevchenko <andy.shevchneko@gmail.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since v1: use octal numbers
>
> drivers/platform/x86/samsung-laptop.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index 763d97cbbe53..9aa0de8b7581 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -1296,12 +1296,12 @@ static void samsung_debugfs_init(struct samsung_laptop *samsung)
> debugfs_create_u32("d1", 0644, root, &samsung->debug.data.d1);
> debugfs_create_u16("d2", 0644, root, &samsung->debug.data.d2);
> debugfs_create_u8("d3", 0644, root, &samsung->debug.data.d3);
> - debugfs_create_blob("data", 0644, root, &samsung->debug.data_wrapper);
> - debugfs_create_blob("f0000_segment", 0600, root,
> + debugfs_create_blob("data", 0444, root, &samsung->debug.data_wrapper);
> + debugfs_create_blob("f0000_segment", 0400, root,
> &samsung->debug.f0000_wrapper);
> debugfs_create_file("call", S_IFREG | 0444, root, samsung,
> &samsung_laptop_call_fops);
> - debugfs_create_blob("sdiag", 0644, root, &samsung->debug.sdiag_wrapper);
> + debugfs_create_blob("sdiag", 0444, root, &samsung->debug.sdiag_wrapper);
> }
>
> static void samsung_sabi_exit(struct samsung_laptop *samsung)
> --
> 2.30.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-04 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 17:00 [PATCH v2 1/2] platform/x86: samsung-laptop: use octal numbers for rwx file permissions Wolfram Sang
2021-05-04 17:00 ` [PATCH v2 2/2] platform/x86: samsung-laptop: set debugfs blobs to read only Wolfram Sang
2021-05-04 17:38 ` Andy Shevchenko [this message]
2021-05-04 18:10 ` Wolfram Sang
2021-05-04 17:35 ` [PATCH v2 1/2] platform/x86: samsung-laptop: use octal numbers for rwx file permissions Andy Shevchenko
2021-05-04 17:37 ` Andy Shevchenko
2021-05-17 10:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vc8OGDB0=ta_GLg3Bjv5NK32dMuuaPTX-ETXRDHtRpxnA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).