From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750776AbdE0UpY (ORCPT <rfc822;w@1wt.eu>);
        Sat, 27 May 2017 16:45:24 -0400
Received: from mail-qk0-f171.google.com ([209.85.220.171]:35671 "EHLO
        mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750746AbdE0UpX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 27 May 2017 16:45:23 -0400
MIME-Version: 1.0
In-Reply-To: <20170526160936.54265-25-mika.westerberg@linux.intel.com>
References: <20170526160936.54265-1-mika.westerberg@linux.intel.com> <20170526160936.54265-25-mika.westerberg@linux.intel.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Sat, 27 May 2017 23:45:21 +0300
Message-ID: <CAHp75Vc8pDPGrJH=UixW-r+kyT5K7wQXs8aN=SzooZpH9qnUcA@mail.gmail.com>
Subject: Re: [PATCH v2 24/27] thunderbolt: Add support for Internal Connection
 Manager (ICM)
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Lukas Wunner <lukas@wunner.de>, Amir Levy <amir.jer.levy@intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Mario Limonciello <Mario.Limonciello@dell.com>,
        Jared.Dominguez@dell.com,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:

> +static inline u8 dual_link_from_link(u8 link)
> +{
> +       return link ? ((link - 1) ^ 0x01) + 1 : 0;
> +}

I have got better one (IIUC):

      return (link + 1) ^ 0x01) - 1;

-- 
With Best Regards,
Andy Shevchenko