From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1955056AbdDYWEP (ORCPT ); Tue, 25 Apr 2017 18:04:15 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:34218 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1955040AbdDYWEH (ORCPT ); Tue, 25 Apr 2017 18:04:07 -0400 MIME-Version: 1.0 In-Reply-To: <20170425173700.124ee74d@blatinox-laptop.localdomain> References: <20170419203819.21951-1-jeremy.lefaure@lse.epita.fr> <20170421190929.7e90e8b2@blatinox-laptop.localdomain> <20170425173700.124ee74d@blatinox-laptop.localdomain> From: Andy Shevchenko Date: Wed, 26 Apr 2017 01:04:05 +0300 Message-ID: Subject: Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type To: =?UTF-8?B?SsOpcsOpbXkgTGVmYXVyZQ==?= Cc: David Howells , linux-cachefs@redhat.com, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3PM4QmD013161 On Wed, Apr 26, 2017 at 12:37 AM, Jérémy Lefaure wrote: > On Tue, 25 Apr 2017 00:47:41 +0300 > Andy Shevchenko wrote: > Ok I get it. But changing the format can break the userland tool > anyway, can't it ? For example if a userland tool expects the value 75, > it won't read it properpy in BCD. Maybe. >> So, if it's okay in this, perhaps paragraph explaining side effects in >> commit message would be good to have/ >> > Maybe the best fix would be to increase the size of the _type buffer to > 4 so the unsigned byte can fit in it. And change the documentation to > decimal value. What do you think about this solution ? Yes, it would work. -- With Best Regards, Andy Shevchenko