[linux-next:master 11232/13260] drivers/platform/x86/thinkpad_acpi.c:9636:25: sparse: sparse: symbol 'dev_attr_charge_start_threshold' was not declared. Should it be

[linux-next:master 11232/13260] drivers/platform/x86/thinkpad_acpi.c:9636:25: sparse: sparse: symbol 'dev_attr_charge_start_threshold' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   01830e6c042e8eb6eb202e05d7df8057135b4c26
commit: e33929537b76486d2ed576a0d9ce3ebff51bf851 [11232/13260] platform/x86: thinkpad_acpi: use standard charge control attribute names
config: x86_64-randconfig-s021-20200801 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-115-g5fc204f2-dirty
        git checkout e33929537b76486d2ed576a0d9ce3ebff51bf851
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/platform/x86/thinkpad_acpi.c:9636:25: sparse: sparse: symbol 'dev_attr_charge_start_threshold' was not declared. Should it be static?
>> drivers/platform/x86/thinkpad_acpi.c:9642:25: sparse: sparse: symbol 'dev_attr_charge_stop_threshold' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31488 bytes --]

[RFC PATCH linux-next] platform/x86: thinkpad_acpi: dev_attr_charge_start_threshold can be static

[kernel test robot]

Fixes: e33929537b76 ("platform/x86: thinkpad_acpi: use standard charge control attribute names")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 thinkpad_acpi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 9eda2f84a3cf98..4864a5c189d464 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -9633,13 +9633,13 @@ static ssize_t charge_control_end_threshold_store(struct device *dev,
 
 static DEVICE_ATTR_RW(charge_control_start_threshold);
 static DEVICE_ATTR_RW(charge_control_end_threshold);
-struct device_attribute dev_attr_charge_start_threshold = __ATTR(
+static struct device_attribute dev_attr_charge_start_threshold = __ATTR(
 	charge_start_threshold,
 	0644,
 	charge_control_start_threshold_show,
 	charge_control_start_threshold_store
 );
-struct device_attribute dev_attr_charge_stop_threshold = __ATTR(
+static struct device_attribute dev_attr_charge_stop_threshold = __ATTR(
 	charge_stop_threshold,
 	0644,
 	charge_control_end_threshold_show,

Re: [RFC PATCH linux-next] platform/x86: thinkpad_acpi: dev_attr_charge_start_threshold can be static

[Andy Shevchenko]

On Sat, Aug 1, 2020 at 11:38 AM kernel test robot <lkp@intel.com> wrote:

Thanks and sorry folks, Hulk robot was faster, and TBH their patch
looks much better (proper commit message applied). Perhaps something
LKP should work on?

> Fixes: e33929537b76 ("platform/x86: thinkpad_acpi: use standard charge control attribute names")
> Signed-off-by: kernel test robot <lkp@intel.com>


-- 
With Best Regards,
Andy Shevchenko

Re: [kbuild-all] Re: [RFC PATCH linux-next] platform/x86: thinkpad_acpi: dev_attr_charge_start_threshold can be static

[Rong Chen]

On 8/1/20 7:45 PM, Andy Shevchenko wrote:
> On Sat, Aug 1, 2020 at 11:38 AM kernel test robot <lkp@intel.com> wrote:
>
> Thanks and sorry folks, Hulk robot was faster, and TBH their patch
> looks much better (proper commit message applied). Perhaps something
> LKP should work on?

Hi Andy,

Thanks for the advice, we'll improve the commit message.

Best Regards,
Rong Chen

>
>> Fixes: e33929537b76 ("platform/x86: thinkpad_acpi: use standard charge control attribute names")
>> Signed-off-by: kernel test robot <lkp@intel.com>
>