From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Mark Brown <broonie@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Sascha Hauer <kernel@pengutronix.de>,
stable@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] driver core: clear deferred probe reason on probe retry
Date: Thu, 18 Mar 2021 14:47:58 +0200 [thread overview]
Message-ID: <CAHp75VcFy1=p6x0nj6wC-tK5ph6Puvx++8aVALLC0WTrkoN8AA@mail.gmail.com> (raw)
In-Reply-To: <20210318073921.13093-1-a.fatoum@pengutronix.de>
On Thu, Mar 18, 2021 at 9:39 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> When retrying a deferred probe, any old defer reason string should be
> discarded. Otherwise, if probe is deferred again at a different spot,
probe -> the probe
> but without setting a message, a now incorrect probe reason will remain.
a now incorrect -> now the incorrect
> This was observed with the i.MX I2C driver, which ultimately failed
> to probe due to lack of the GPIO driver. The probe defer for GPIO
> doesn't record a message, but a previous probe defer to clock_get did.
> This had the effect that /sys/kernel/debug/devices_deferred listed
> a misleading probe deferral reason.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: stable@kernel.org
> Fixes: d090b70ede02 ("driver core: add deferring probe reason to devices_deferred property")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/base/dd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 9179825ff646..e2cf3b29123e 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -97,6 +97,9 @@ static void deferred_probe_work_func(struct work_struct *work)
>
> get_device(dev);
>
> + kfree(dev->p->deferred_probe_reason);
> + dev->p->deferred_probe_reason = NULL;
> +
> /*
> * Drop the mutex while probing each device; the probe path may
> * manipulate the deferred list
> --
> 2.29.2
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-03-18 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 7:39 [PATCH 1/2] driver core: clear deferred probe reason on probe retry Ahmad Fatoum
2021-03-18 7:39 ` [PATCH 2/2] driver core: add helper for deferred probe reason setting Ahmad Fatoum
2021-03-22 8:20 ` Andrzej Hajda
2021-03-18 12:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcFy1=p6x0nj6wC-tK5ph6Puvx++8aVALLC0WTrkoN8AA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=a.hajda@samsung.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).