Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Maarten Maathuis <madman2003@gmail.com>
Cc: AceLan Kao <acelan.kao@canonical.com>,
	"dvhart@infradead.org" <dvhart@infradead.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Maarten Maathuis <madman2003@shikahr.net>
Subject: Re: [PATCH] platform/x86/intel-vbtn: add volume up and down
Date: Tue, 25 Apr 2017 15:13:27 +0300	[thread overview]
Message-ID: <CAHp75VcJZrVNMKNx=bFoz2PMw3cB98bHsTcSYU1PVTnBveciMw@mail.gmail.com> (raw)
In-Reply-To: <20170424213521.10406-1-madman2003@shikahr.net>

On Tue, Apr 25, 2017 at 12:35 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
> Tested on HP Elite X2 1012 G1.
> Matches event report of Lenovo Helix 2
> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>
> V2: Fix indent and add sign-off
> V3: Missing whitespace correction

Slightly modified (*) version pushed to testing, thanks!

*) Fixed subject, removed changelog from commit message, improved indentation

>
> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
> ---
>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 554e82ebe83c..dc270fe793a1 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>  static const struct key_entry intel_vbtn_keymap[] = {
>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP } },     /* volume-up key press */
> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>         { KE_END },
>  };
>
> --
> 2.12.2
>

-- 
With Best Regards,
Andy Shevchenko