From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Darren Hart <dvhart@infradead.org> Cc: Andy Shevchenko <andy@infradead.org>, Platform Driver <platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Carlo Caione <carlo@caione.org> Subject: Re: [PATCH 2/9] platform/x86: hp-wmi: Add bios_args initializer Date: Thu, 20 Apr 2017 10:37:45 +0300 [thread overview] Message-ID: <CAHp75VcMsmqsuZZmoRy7L7d5xzZzWyxjQFUBvwTmFhkXCtaLVg@mail.gmail.com> (raw) In-Reply-To: <7a898f33a9032f7a65c14f4c131386e8a548ba2e.1492654448.git.dvhart@infradead.org> On Thu, Apr 20, 2017 at 5:25 AM, Darren Hart <dvhart@infradead.org> wrote: > From: "Darren Hart (VMware)" <dvhart@infradead.org> > > Cleanup the hp_wmi_perform_query function some by providing a bios_args > initializer. No functional changes. Is it going to be used only once? If so, I would go with current code. > > Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org> > --- > drivers/platform/x86/hp-wmi.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index e772105..aa9d99c 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -93,6 +93,13 @@ struct bios_args { > u32 data; > }; > > +#define BIOS_ARGS_INIT(write, ctype, size) \ > + (struct bios_args) { .signature = 0x55434553, \ > + .command = (write) ? 0x2 : 0x1, \ > + .commandtype = (ctype), \ > + .datasize = (size), \ > + .data = 0 } > + > struct bios_return { > u32 sigpass; > u32 return_code; > @@ -190,18 +197,12 @@ static struct rfkill2_device rfkill2[HPWMI_MAX_RFKILL2_DEVICES]; > static int hp_wmi_perform_query(int query, int write, void *buffer, > int insize, int outsize) > { > - struct bios_return *bios_return; > - int actual_outsize; > - union acpi_object *obj; > - struct bios_args args = { > - .signature = 0x55434553, > - .command = write ? 0x2 : 0x1, > - .commandtype = query, > - .datasize = insize, > - .data = 0, > - }; > + struct bios_args args = BIOS_ARGS_INIT(write, query, insize); > struct acpi_buffer input = { sizeof(struct bios_args), &args }; > struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; > + struct bios_return *bios_return; > + union acpi_object *obj; > + int actual_outsize; > u32 rc; > > if (WARN_ON(insize > sizeof(args.data))) > -- > 2.9.3 > -- With Best Regards, Andy Shevchenko
next prev parent reply other threads:[~2017-04-20 7:37 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-20 2:25 [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups Darren Hart 2017-04-20 2:25 ` [PATCH 1/9] platform/x86: hp-wmi: Cleanup local variable declarations Darren Hart 2017-04-20 2:25 ` [PATCH 2/9] platform/x86: hp-wmi: Add bios_args initializer Darren Hart 2017-04-20 7:37 ` Andy Shevchenko [this message] 2017-04-20 2:25 ` [PATCH 3/9] platform/x86: hp-wmi: Standardize enum usage for constants Darren Hart 2017-04-20 7:19 ` Andy Shevchenko 2017-04-20 20:31 ` Darren Hart 2017-04-20 2:25 ` [PATCH 4/9] platform/x86: hp-wmi: Refactor redundant HPWMI_READ functions Darren Hart 2017-04-20 2:25 ` [PATCH 5/9] platform/x86: hp-wmi: Cleanup wireless get_(hw|sw)state functions Darren Hart 2017-04-20 2:25 ` [PATCH 6/9] platform/x86: hp-wmi: Refactor dock and tablet state fetchers Darren Hart 2017-04-20 2:25 ` [PATCH 7/9] platform/x86: hp-wmi: Use DEVICE_ATTR_(RO|RW) helper macros Darren Hart 2017-04-20 2:25 ` [PATCH 8/9] platform/x86: hp-wmi: Do not shadow errors in sysfs show functions Darren Hart 2017-04-20 2:25 ` [PATCH 9/9] platform/x86: hp-wmi: Cleanup exit paths Darren Hart 2017-04-20 7:38 ` [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups Andy Shevchenko 2017-04-20 20:19 ` Darren Hart 2017-04-20 9:06 ` Carlo Caione
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75VcMsmqsuZZmoRy7L7d5xzZzWyxjQFUBvwTmFhkXCtaLVg@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=andy@infradead.org \ --cc=carlo@caione.org \ --cc=dvhart@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ --subject='Re: [PATCH 2/9] platform/x86: hp-wmi: Add bios_args initializer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).