From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Aleh Filipovich <aleh@vaolix.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: Add keymap entry for lid flip action on Asus UX360
Date: Wed, 15 Aug 2018 13:15:52 +0300 [thread overview]
Message-ID: <CAHp75VcMxMMgLS5y1=k2wMHy5HNbBVgJFMNJ0gErsExss4K65Q@mail.gmail.com> (raw)
In-Reply-To: <04607a59-7e47-5463-7ff6-cb1aae7e3626@vaolix.com>
On Fri, Aug 10, 2018 at 11:07 PM, Aleh Filipovich <aleh@vaolix.com> wrote:
> Add entry to WMI keymap for lid flip event on Asus UX360.
>
> On Asus Zenbook ux360 flipping lid from/to tablet mode triggers
> keyscan code 0xfa which cannot be handled and results in kernel
> log message "Unknown key fa pressed".
>
>
Pushed to my review and testing queue, thanks!
P.S. your patch is mangled, please, pay attention to the format next time.
> Signed-off-by: Aleh Filipovich<aleh@appnexus.com>
> ---
> drivers/platform/x86/asus-nb-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index 136ff2b4cce5..db2af09067db 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
> { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
> { KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
> + { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
> { KE_END, 0},
> };
>
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-08-15 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 20:07 [PATCH] platform/x86: asus-wmi: Add keymap entry for lid flip action on Asus UX360 Aleh Filipovich
2018-08-15 10:15 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcMxMMgLS5y1=k2wMHy5HNbBVgJFMNJ0gErsExss4K65Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=aleh@vaolix.com \
--cc=andy@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).