From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87147C433ED for ; Sun, 11 Apr 2021 18:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CCB260240 for ; Sun, 11 Apr 2021 18:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235779AbhDKSIB (ORCPT ); Sun, 11 Apr 2021 14:08:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235284AbhDKSH7 (ORCPT ); Sun, 11 Apr 2021 14:07:59 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18BD8C061574; Sun, 11 Apr 2021 11:07:40 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id a85so7245907pfa.0; Sun, 11 Apr 2021 11:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jEcbYX8Y08bH641l8oqV2fm1Zee8I5Yt330pQIjrzVk=; b=pgYrJQULHlSnRawowMrMHD1vjVKyGInW9gfvEHYsWwQM8Mr4xTjOMBigglW3/iQ9dG DW2f/ffyxMzB+/hksKSaYgkuN/gN9gRnF8yKuaVZtLHp+VV9niC4FdBet0Vk+bRTJNOP qY6pggvzlbs8aCOxit3o+h5BADahAuwZJpw8OeZuZormFZ0e7KQ3QkH6Tt6vc3DbXDHi axOM1mibDy/zuunSfLv+OdnXVzEH8X4d3/u6cL8AfgEllSe75XShqY9IH7g1VG3HoNjW tcGftpvdXrbtmCa9sN3gFLKhimxnPWnsiZLzZIo2L55QphYULMR9/KjXuZDfd/jZuKbV WRTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jEcbYX8Y08bH641l8oqV2fm1Zee8I5Yt330pQIjrzVk=; b=laQamOeMZnyOV3+Q3NMqJmtf3uIaUA/UJUs279mYZC+2PbjHS4FF1LLQFXtXPXEViD i6dRwPZAwoH9KdN3k+NaDtywqJTd5FobgW3X3lxG6/0HKG7CzXERTGBPoqs4fvnlJBeY 4QddSX19mK98/7oLFizsEcU1kTzzsGM1JlB1+rIR0SSF/3mHBZD6MoGvR2ZrBa9FCokY 4vjX6SRrxIfu/1ENsYewrUVXXCUFm0dbn3Jqu5YbbrwDIbS5Uf4wKlb97GN07Q+rniT7 7KJDPcYWzHzgbwrEY2JfBIgdSm0tbDMsLe4qu8G1v7XoxrMKWLnGUnycdQSTObaXXJpL B2+w== X-Gm-Message-State: AOAM531J0Voncr50xp84fAFbwq8lyNrmEoHHjj7pfDNtnZ1PxyzIMz9N qOO0NV0YkGvI6FNbcG8l4BrDHGYjWpM5txrukUY= X-Google-Smtp-Source: ABdhPJwkzlrouaFhCAJ7iLqKaaTDjIhbP3qlzq8AMegpU8mUaAcB9EY6MM44FCYn9Z2x5IstFiib/ie6d6/vfWTp7FU= X-Received: by 2002:a63:3e4b:: with SMTP id l72mr22714087pga.203.1618164459392; Sun, 11 Apr 2021 11:07:39 -0700 (PDT) MIME-Version: 1.0 References: <20210407182147.77221-1-puranjay12@gmail.com> <20210407182147.77221-3-puranjay12@gmail.com> <20210411155420.318e866e@jic23-huawei> In-Reply-To: <20210411155420.318e866e@jic23-huawei> From: Andy Shevchenko Date: Sun, 11 Apr 2021 21:07:22 +0300 Message-ID: Subject: Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117 To: Jonathan Cameron Cc: Puranjay Mohan , Alexandru Ardelean , devicetree , Hartmut Knaack , linux-iio , Linux Kernel Mailing List , Lars-Peter Clausen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 11, 2021 at 5:53 PM Jonathan Cameron wrote: > > On Wed, 7 Apr 2021 23:51:47 +0530 > Puranjay Mohan wrote: > > > TMP117 is a Digital temperature sensor with integrated Non-Volatile memory. > > Add support for tmp117 driver in iio subsystem. ... > > + off = clamp(val, S16_MIN, S16_MAX); > > With a C=1 W=1 build (sparse an lots of warnings) this causes problems because > the S16_MIN and S16_MAX are as you might imagine s16 values whereas val is > an int. I've added casts to force S16_MIN and S16_MAX to ints as well. Good point, but better is to use clamp_t(s16, ...) rather than explicit casting. I always consider explicit casting in C (and esp. in Linux kernel) is a red flag. Should be really rarely needed. > > + if (off == data->calibbias) > > + return 0; -- With Best Regards, Andy Shevchenko