From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Andrei Lalaev <andrei.lalaev@emlid.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: of: fix bounds check for valid mask
Date: Tue, 12 Apr 2022 11:36:56 +0300 [thread overview]
Message-ID: <CAHp75VcWvmMMjgNEUQK2AqmUzrx3CADEQq6XieFiix+=FBgqSg@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=MfakYvQUW4NLWCrm5yVA185X4t__aB3r4-9xTh8YJaq8g@mail.gmail.com>
On Tue, Apr 12, 2022 at 11:28 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Mon, Apr 11, 2022 at 2:17 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
...
> > OTOH, the current implementation suggests that we have start,end
> > rather than start,count. What does documentation tell about it? Does
> > it need to be fixed?
> Thanks Andy, I rushed this one. Backing it out.
With the last analysis by Andrei I think the patch is correct. I
suggest waiting for v2 with a better commit message.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-04-12 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 6:33 [PATCH] gpiolib: of: fix bounds check for valid mask Andrei Lalaev
2022-04-11 10:48 ` Bartosz Golaszewski
2022-04-11 12:12 ` Andy Shevchenko
2022-04-11 14:46 ` Andrei Lalaev
2022-04-11 16:55 ` Andy Shevchenko
2022-04-12 7:03 ` Andrei Lalaev
2022-04-12 8:35 ` Andy Shevchenko
2022-04-12 8:28 ` Bartosz Golaszewski
2022-04-12 8:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcWvmMMjgNEUQK2AqmUzrx3CADEQq6XieFiix+=FBgqSg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andrei.lalaev@emlid.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).