From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch
Date: Thu, 5 Jan 2017 19:44:21 +0200 [thread overview]
Message-ID: <CAHp75VcggLJRpjW6m=5bCRH9wqrz99NHfswNf6zae4yPqnP0_Q@mail.gmail.com> (raw)
In-Reply-To: <7a730dc9-ac17-35c4-fe76-dfc94e5ecd95@ce.jp.nec.com>
On Thu, Jan 5, 2017 at 3:03 AM, Junichi Nomura <j-nomura@ce.jp.nec.com> wrote:
> We allocate struct ucode_patch here.
>
> "size" is a size of microcode data and used for kmemdup() later
> in this function.
>
> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
> Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
>
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index aee3cb5..042f329 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -150,7 +150,7 @@ static struct ucode_patch *__alloc_microcode_buf(void *data, unsigned int size)
> {
> struct ucode_patch *p;
>
> - p = kzalloc(size, GFP_KERNEL);
> + p = kzalloc(sizeof(struct ucode_patch), GFP_KERNEL);
Perhaps sizeof(*p) ?
> if (!p)
> return ERR_PTR(-ENOMEM);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-01-05 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 1:03 [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Junichi Nomura
2017-01-05 10:23 ` Borislav Petkov
2017-01-05 17:44 ` Andy Shevchenko [this message]
2017-01-05 23:52 ` Junichi Nomura
2017-01-06 0:02 ` Borislav Petkov
2017-01-06 0:14 ` Junichi Nomura
2017-01-06 10:56 ` Borislav Petkov
2017-01-09 22:17 ` [tip:x86/urgent] " tip-bot for Junichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcggLJRpjW6m=5bCRH9wqrz99NHfswNf6zae4yPqnP0_Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).