From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Arnd Bergmann <arnd.bergmann@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Zha Qipeng <qipeng.zha@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH] platform/x86: fix intel_punit_ipc.c build errors
Date: Fri, 17 Aug 2018 14:00:02 +0300 [thread overview]
Message-ID: <CAHp75Vch70rk+zZ2wv=qjPzEDhAnqRBwBuDEU3x40=+fVZhF1g@mail.gmail.com> (raw)
In-Reply-To: <aee82dc5-cc0f-0698-04a8-a5857fce9791@infradead.org>
On Wed, Aug 15, 2018 at 7:12 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors by #including <linux/io.h>.
>
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
> ../drivers/platform/x86/intel_punit_ipc.c:55:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
> return readl(ipcdev->base[type][BASE_IFACE]);
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_write_cmd':
> ../drivers/platform/x86/intel_punit_ipc.c:60:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
> writel(cmd, ipcdev->base[type][BASE_IFACE]);
>
Thanks, pushed to our for-next queue, with Fixes tag appended.
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Zha Qipeng <qipeng.zha@intel.com>
> Cc: platform-driver-x86@vger.kernel.org
> ---
> Found in linux-next but applies to current mainline also.
>
> drivers/platform/x86/intel_punit_ipc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20180815.orig/drivers/platform/x86/intel_punit_ipc.c
> +++ linux-next-20180815/drivers/platform/x86/intel_punit_ipc.c
> @@ -18,6 +18,7 @@
> #include <linux/bitops.h>
> #include <linux/device.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/platform_device.h>
> #include <asm/intel_punit_ipc.h>
>
>
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-08-17 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 16:12 [PATCH] platform/x86: fix intel_punit_ipc.c build errors Randy Dunlap
2018-08-17 11:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vch70rk+zZ2wv=qjPzEDhAnqRBwBuDEU3x40=+fVZhF1g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd.bergmann@linaro.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).