[PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile

[PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile

[Andy Shevchenko]

The 'objs' is for user space tools, for the kernel modules
we should use 'y'.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/platform/x86/intel/int3472/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/int3472/Makefile b/drivers/platform/x86/intel/int3472/Makefile
index 48bd97f0a04e..2362e04db18d 100644
--- a/drivers/platform/x86/intel/int3472/Makefile
+++ b/drivers/platform/x86/intel/int3472/Makefile
@@ -1,5 +1,5 @@
 obj-$(CONFIG_INTEL_SKL_INT3472)		+= intel_skl_int3472.o
-intel_skl_int3472-objs			:= intel_skl_int3472_common.o \
+intel_skl_int3472-y			:= intel_skl_int3472_common.o \
 					   intel_skl_int3472_discrete.o \
 					   intel_skl_int3472_tps68470.o \
 					   intel_skl_int3472_clk_and_regulator.o
-- 
2.30.2

Re: [PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile

[Daniel Scally]

Hi Andy

On 06/08/2021 16:49, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.


Oops, now you mention it I remember you saying that for the cio2-bridge
code too - thanks.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


Reviewed-by: Daniel Scally <djrscally@gmail.com>

> ---
>  drivers/platform/x86/intel/int3472/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/Makefile b/drivers/platform/x86/intel/int3472/Makefile
> index 48bd97f0a04e..2362e04db18d 100644
> --- a/drivers/platform/x86/intel/int3472/Makefile
> +++ b/drivers/platform/x86/intel/int3472/Makefile
> @@ -1,5 +1,5 @@
>  obj-$(CONFIG_INTEL_SKL_INT3472)		+= intel_skl_int3472.o
> -intel_skl_int3472-objs			:= intel_skl_int3472_common.o \
> +intel_skl_int3472-y			:= intel_skl_int3472_common.o \
>  					   intel_skl_int3472_discrete.o \
>  					   intel_skl_int3472_tps68470.o \
>  					   intel_skl_int3472_clk_and_regulator.o

Re: [PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile

[Andy Shevchenko]

On Sat, Aug 7, 2021 at 3:20 AM Daniel Scally <djrscally@gmail.com> wrote:
> On 06/08/2021 16:49, Andy Shevchenko wrote:
> > The 'objs' is for user space tools, for the kernel modules
> > we should use 'y'.
>
> Oops, now you mention it I remember you saying that for the cio2-bridge
> code too - thanks.

Just for the sake of reference (I spent some time to realize from
where I have got this):
https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#composite-userspace-programs
(Note, that there is the first section with the first "objs" mention)

...

> Reviewed-by: Daniel Scally <djrscally@gmail.com>

Thanks!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile

[Andy Shevchenko]

On Sat, Aug 7, 2021 at 12:46 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sat, Aug 7, 2021 at 3:20 AM Daniel Scally <djrscally@gmail.com> wrote:
> > On 06/08/2021 16:49, Andy Shevchenko wrote:
> > > The 'objs' is for user space tools, for the kernel modules
> > > we should use 'y'.
> >
> > Oops, now you mention it I remember you saying that for the cio2-bridge
> > code too - thanks.
>
> Just for the sake of reference (I spent some time to realize from
> where I have got this):
> https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#composite-userspace-programs
> (Note, that there is the first section with the first "objs" mention)

Actually this one
https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#composite-host-programs
But it doesn't change the point.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile

[Hans de Goede]

Hi,

On 8/6/21 5:49 PM, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/intel/int3472/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/int3472/Makefile b/drivers/platform/x86/intel/int3472/Makefile
> index 48bd97f0a04e..2362e04db18d 100644
> --- a/drivers/platform/x86/intel/int3472/Makefile
> +++ b/drivers/platform/x86/intel/int3472/Makefile
> @@ -1,5 +1,5 @@
>  obj-$(CONFIG_INTEL_SKL_INT3472)		+= intel_skl_int3472.o
> -intel_skl_int3472-objs			:= intel_skl_int3472_common.o \
> +intel_skl_int3472-y			:= intel_skl_int3472_common.o \
>  					   intel_skl_int3472_discrete.o \
>  					   intel_skl_int3472_tps68470.o \
>  					   intel_skl_int3472_clk_and_regulator.o
>