From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>,
Jeremy Cline <jeremy@jcline.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hans de Goede <hdegoede@redhat.com>,
Lars Kellogg-Stedman <lars@oddbit.com>,
Steven Presser <steve@pressers.name>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200
Date: Tue, 30 Jan 2018 18:40:16 +0200 [thread overview]
Message-ID: <CAHp75VchRJzp1CM33q18e9x8Uq7bNrPZykz-GdpRgB3=y2C+KQ@mail.gmail.com> (raw)
In-Reply-To: <20180130160107.000006df@huawei.com>
On Tue, Jan 30, 2018 at 6:01 PM, Jonathan Cameron
<Jonathan.Cameron@huawei.com> wrote:
> On Mon, 29 Jan 2018 16:07:02 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>> > But that would take much longer. Feel free to propose it and a patch
>> > removing the ifdef fun if you like!
>> Where can I see the patch?
> Doh. I clearly forgot to push out. Should be able to push to
> iio.git on kernel.org later.
Thanks, I can see it now.
This patch almost wrong. Not by functionality it brings, but by style.
I'll send soon a series of fixes to the driver (compile tested only)
to provide my view on the matters.
P.S. In the future (I have some kind of deja vu I have told this
already to someone), please, Cc one or more of Rafael, Mika and/or me
for ACPI matters.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-01-30 16:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 17:52 [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200 Jeremy Cline
2017-12-10 18:21 ` Jonathan Cameron
2018-01-09 21:24 ` Jeremy Cline
2018-01-14 10:43 ` Jonathan Cameron
2018-01-28 9:40 ` Jonathan Cameron
2018-01-29 14:07 ` Andy Shevchenko
2018-01-30 16:01 ` Jonathan Cameron
2018-01-30 16:40 ` Andy Shevchenko [this message]
2018-01-30 17:05 ` Andy Shevchenko
[not found] ` <CADXBfmvKF_doLv0Vg0TY4cH_rDBEP5NvJ4jHJf85iuOjJB6TzA@mail.gmail.com>
2018-01-30 17:38 ` Andy Shevchenko
2018-01-30 18:08 ` Andy Shevchenko
2018-01-30 18:33 ` Jonathan Cameron
2018-01-30 18:46 ` Jonathan Cameron
2018-01-30 18:47 ` Andy Shevchenko
2018-01-30 18:34 ` Steven Presser
2018-01-30 19:05 ` Andy Shevchenko
2018-01-30 19:27 ` Steven Presser
2018-01-30 20:12 ` Andy Shevchenko
2018-01-30 21:20 ` Andy Shevchenko
2018-01-31 10:55 ` Jonathan Cameron
2018-02-04 18:25 ` Steven Presser
2018-02-15 12:50 ` Andy Shevchenko
[not found] ` <CADXBfmsJPv9Q6W+j=RdzUAHJ9Ya-6zrV9Ns7KMNBHOAnn_BZuA@mail.gmail.com>
2018-02-16 14:50 ` Andy Shevchenko
2018-02-04 17:58 ` Steven Presser
2018-02-06 19:47 ` Andy Shevchenko
2018-01-31 11:43 ` Hans de Goede
2018-01-31 12:25 ` Andy Shevchenko
2018-01-31 14:58 ` Hans de Goede
2018-01-31 15:19 ` Andy Shevchenko
2018-01-31 19:53 ` Jeremy Cline
2018-01-30 15:22 ` Jeremy Cline
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VchRJzp1CM33q18e9x8Uq7bNrPZykz-GdpRgB3=y2C+KQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=hdegoede@redhat.com \
--cc=jeremy@jcline.org \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lars@oddbit.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pmeerw@pmeerw.net \
--cc=steve@pressers.name \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).