Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Vadym Kochan <vadym.kochan@plvision.eu>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>, Andrew Lunn <andrew@lunn.ch>,
	Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
	Serhiy Boiko <serhiy.boiko@plvision.eu>,
	Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
	Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
	Taras Chornyi <taras.chornyi@plvision.eu>,
	Andrii Savka <andrii.savka@plvision.eu>,
	Network Development <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mickey Rachamim <mickeyr@marvell.com>
Subject: Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices
Date: Thu, 3 Sep 2020 18:35:34 +0300	[thread overview]
Message-ID: <CAHp75VcmPnmgxgE+NCTN71Wq17LQjjx8cJOR34AmuLuRFQ4cRg@mail.gmail.com> (raw)
In-Reply-To: <CA+FuTSfMRhEZ5c2CWaN_F3ASDgvV7eQ4q6zVuY-FvgLqsqYecw@mail.gmail.com>

On Thu, Sep 3, 2020 at 6:23 PM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
> On Wed, Sep 2, 2020 at 5:37 PM Vadym Kochan <vadym.kochan@plvision.eu> wrote:

...

> > +static int prestera_is_valid_mac_addr(struct prestera_port *port, u8 *addr)
> > +{
> > +       if (!is_valid_ether_addr(addr))
> > +               return -EADDRNOTAVAIL;
> > +
> > +       if (memcmp(port->sw->base_mac, addr, ETH_ALEN - 1))
>
> Why ETH_ALEN - 1?

We even have a lot of helpers specifically for ethernet MACs.
Starting from [1] till almost the end of the file. Here [2] can be
used (or its unaligned counterpart).

[1]: https://elixir.bootlin.com/linux/latest/source/include/linux/etherdevice.h#L67
[2]: https://elixir.bootlin.com/linux/latest/source/include/linux/etherdevice.h#L67

> > +               return -EINVAL;
> > +
> > +       return 0;
> > +}

> > +       memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
>
> Is addr_len ever not ETH_ALEN for this device?

And if it is ETH_ALEN, here is [3].
[3]: https://elixir.bootlin.com/linux/latest/source/include/linux/etherdevice.h#L287

-- 
With Best Regards,
Andy Shevchenko