From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Rokosov <DDRokosov@sberdevices.ru>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"stano.jakubek@gmail.com" <stano.jakubek@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"stephan@gerhold.net" <stephan@gerhold.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver
Date: Thu, 4 Aug 2022 20:30:12 +0200 [thread overview]
Message-ID: <CAHp75Vcn6JCDDvugop2Ho1cayLi1CX78O42v3GifvnuSY5fvPA@mail.gmail.com> (raw)
In-Reply-To: <20220804181723.4bljpxcwkj6cnn2f@CAB-WSD-L081021.sigma.sbrf.ru>
On Thu, Aug 4, 2022 at 8:17 PM Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:
> On Wed, Aug 03, 2022 at 07:16:13PM +0000, Dmitry Rokosov wrote:
> > On Wed, Aug 03, 2022 at 07:49:33PM +0200, Andy Shevchenko wrote:
> > > On Wed, Aug 3, 2022 at 3:11 PM Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:
Please, remove unneeded context when replying!
...
> > > > + dev_err(dev, "cannot %s register %u from debugfs (%d)\n",
> > > > + readval ? "read" : "write", reg, err);
> > >
> > > You may consider taking [1] as a precursor here and use str_read_write().
> > >
> > > [1]: https://lore.kernel.org/linux-i2c/20220703154232.55549-1-andriy.shevchenko@linux.intel.com/
> >
> > Oh, really... Thank you for suggestion!
>
> I have taken it closer, and it's really helpful and nice, but looks like
> it's not merged to linux-next.
> Please advise how I can use it in the driver. Should I provide
> "Depends-On:" tag as I did for my HZ units patchset?
No, just take that patch into your series.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-04 18:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 13:11 [PATCH v4 0/3] iio: accel: add MSA311 accelerometer driver Dmitry Rokosov
2022-08-03 13:11 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: add MEMSensing Microsystems Co., Ltd Dmitry Rokosov
2022-08-03 13:11 ` [PATCH v4 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver Dmitry Rokosov
2022-08-03 17:49 ` Andy Shevchenko
2022-08-03 19:16 ` Dmitry Rokosov
2022-08-04 18:17 ` Dmitry Rokosov
2022-08-04 18:30 ` Andy Shevchenko [this message]
2022-08-05 14:04 ` Dmitry Rokosov
2022-08-05 16:03 ` Andy Shevchenko
2022-08-05 16:20 ` Dmitry Rokosov
2022-08-05 17:59 ` Andy Shevchenko
2022-08-04 18:28 ` Andy Shevchenko
2022-08-05 14:19 ` Dmitry Rokosov
2022-08-06 14:55 ` Jonathan Cameron
2022-08-09 9:52 ` Dmitry Rokosov
2022-08-09 10:05 ` Andy Shevchenko
2022-08-09 10:35 ` Dmitry Rokosov
2022-08-13 15:27 ` Jonathan Cameron
2022-08-13 15:39 ` Jonathan Cameron
2022-08-03 18:11 ` Christophe JAILLET
2022-08-03 18:39 ` Dmitry Rokosov
2022-08-03 19:18 ` Christophe JAILLET
2022-08-03 19:26 ` Dmitry Rokosov
2022-08-06 15:32 ` Jonathan Cameron
2022-08-09 9:47 ` Dmitry Rokosov
2022-08-13 15:34 ` Jonathan Cameron
2022-08-03 13:11 ` [PATCH v4 3/3] dt-bindings: iio: accel: add dt-binding schema for msa311 accel driver Dmitry Rokosov
2022-08-03 23:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vcn6JCDDvugop2Ho1cayLi1CX78O42v3GifvnuSY5fvPA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=DDRokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stano.jakubek@gmail.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).