From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: qiujiang <qiujiang@huawei.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
linuxarm@huawei.com, haifeng.wei@huawei.com,
charles.chenxin@huawei.com
Subject: Re: [PATCH v5 3/3] gpio: designware: add gpio-signaled acpi event support
Date: Thu, 10 Mar 2016 22:31:43 +0200 [thread overview]
Message-ID: <CAHp75Vcr_uynzQPndYcp5DTVxhD4nMZ_0wz2hxFGqS23=MV6+Q@mail.gmail.com> (raw)
In-Reply-To: <1457077474-124064-4-git-send-email-qiujiang@huawei.com>
On Fri, Mar 4, 2016 at 9:44 AM, qiujiang <qiujiang@huawei.com> wrote:
> This patch adds the support for the gpio-signaled acpi event.
> This is used for power button on hisilicon D02 board, which
> is an arm64 platform.
>
> To support this function, _AEI and _Exx objects must be
> defined in the corresponding GPIO device as follows:
>
> Name (_AEI, ResourceTemplate () {
> GpioInt(Edge, ActiveLow, ExclusiveAndWake, PullUp,
> , " \\_SB.GPI0") {8}
> })
> Method (_E08, 0x0, NotSerialized) {
> Notify (\_SB.PWRB, 0x80)
> }
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: qiujiang <qiujiang@huawei.com>
This one fine to me.
> ---
> drivers/gpio/gpio-dwapb.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 2ae506f..043e1c2 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -28,6 +28,8 @@
> #include <linux/platform_data/gpio-dwapb.h>
> #include <linux/slab.h>
>
> +#include "gpiolib.h"
> +
> #define GPIO_SWPORTA_DR 0x00
> #define GPIO_SWPORTA_DDR 0x04
> #define GPIO_SWPORTB_DR 0x0c
> @@ -437,6 +439,10 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> else
> port->is_registered = true;
>
> + /* Add GPIO-signaled ACPI event support */
> + if (pp->irq)
> + acpi_gpiochip_request_interrupts(&port->gc);
> +
> return err;
> }
>
> --
> 1.9.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2016-03-10 20:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 7:44 [PATCH v5 0/3] "gpio: designware: add gpio-signaled acpi event support for power button" qiujiang
2016-03-04 7:44 ` [PATCH v5 1/3] gpio: designware: convert device node to fwnode qiujiang
2016-03-10 19:09 ` Alan Tull
2016-03-10 20:27 ` Andy Shevchenko
2016-03-11 0:48 ` Jiang Qiu
2016-03-15 12:56 ` Jiang Qiu
2016-03-23 11:41 ` Jiang Qiu
2016-03-23 16:20 ` Alan Tull
2016-03-24 1:24 ` Jiang Qiu
2016-03-11 0:44 ` Jiang Qiu
2016-03-22 10:38 ` Linus Walleij
2016-03-22 15:55 ` Mika Westerberg
2016-03-04 7:44 ` [PATCH v5 2/3] gpio: designware: add acpi binding qiujiang
2016-03-10 20:30 ` Andy Shevchenko
2016-03-04 7:44 ` [PATCH v5 3/3] gpio: designware: add gpio-signaled acpi event support qiujiang
2016-03-10 20:31 ` Andy Shevchenko [this message]
2016-03-09 2:26 ` [PATCH v5 0/3] "gpio: designware: add gpio-signaled acpi event support for power button" Linus Walleij
2016-03-10 20:10 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vcr_uynzQPndYcp5DTVxhD4nMZ_0wz2hxFGqS23=MV6+Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=charles.chenxin@huawei.com \
--cc=gnurou@gmail.com \
--cc=haifeng.wei@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=qiujiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).