From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF75C433E2 for ; Mon, 22 Jun 2020 15:51:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B63220716 for ; Mon, 22 Jun 2020 15:51:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hEAGfP/n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729637AbgFVPvR (ORCPT ); Mon, 22 Jun 2020 11:51:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728431AbgFVPvQ (ORCPT ); Mon, 22 Jun 2020 11:51:16 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90EDAC061573; Mon, 22 Jun 2020 08:51:16 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id ne5so17690pjb.5; Mon, 22 Jun 2020 08:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mpPb3+yNpxwCEjuPN9vujTShlReBQ2Dt+rrRa2Bp2DQ=; b=hEAGfP/nFGOSzQuYQ+mVlTeEXfn4amAcGfX1VdaDPPQmPhJurXb8NVq8CRcydEKsIf Duk388/QhD+XpCFwmhLON1Hz/96s2qi0NKnqqSzCxve7+E/C5RGASHaH+4ZJ1xzZdWMu eaEQCRRKZXDh7ZRuIprzQVVkuHq9vwQrSpGbb0qrXjxEGUTHgAQupJhoNFpYmBnLAvF/ T8Rhl7XYv9bb/HokATYjbec6pMYvKYJ2MMgZa/NDvLOJ5VuKOjZHIIc2pG4Nwzxtd2yF damyeMz2Q2TnjsT+xeW5nPUI5yfnrrIs14QbM9WYp5ODCbVpU8/G9NGA+ZVv8XhHHkPB zQ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mpPb3+yNpxwCEjuPN9vujTShlReBQ2Dt+rrRa2Bp2DQ=; b=DjL83L0t7FZHKcqrnbegEyHkKt+cpGv4A1/8bHghC3ValMzMwX6QFA/i/3CDg7TmAv Zb2Mi5zwfuMQKwhzp/9cGd4MJ+5cFyFAApeI/krFyqkUrCe22McPH6t/O5y5gVWakBI6 ny0dmVYnWa0ZVnhRFs6uiV5mdZMOFLecu25rjfsSqHQgHyXpDKoZZv80SrhO8Yl2VEWg bgB8S8X3b9bwRGAgF15wwt6p5B9QMU7Htday2GgVgTd1vWNypdBZL5yvGnc42HL8NaMT jhFDXN1GoH7u8oqAqodPWhxQbljCi10QcKuoOQnl92rDlLx3SCxcXt+KnQGRJPYb8Cfn NUpw== X-Gm-Message-State: AOAM533MkocMW36wQi1HWR29XB2cGtbBF2DHxGdM1QzfWMA8DK+7yTv0 kOXCSwg3rZ/7G5qMXLdJFN9UVi6QmAMeY5FzQHE= X-Google-Smtp-Source: ABdhPJzv28LTfnWpJp82+S+pzs7++aNj/pUb9dRwcbTfTgiLWqmcLOfQ70fYghDtqny5H6ocNpkQ1poPDlTbaOtfe+I= X-Received: by 2002:a17:90a:ac05:: with SMTP id o5mr19471241pjq.228.1592841076136; Mon, 22 Jun 2020 08:51:16 -0700 (PDT) MIME-Version: 1.0 References: <20200622103817.476-1-nsaenzjulienne@suse.de> <20200622103817.476-7-nsaenzjulienne@suse.de> <0c0546cfe855eee1381c629b2ffd7f65427c7091.camel@suse.de> In-Reply-To: <0c0546cfe855eee1381c629b2ffd7f65427c7091.camel@suse.de> From: Andy Shevchenko Date: Mon, 22 Jun 2020 18:51:03 +0300 Message-ID: Subject: Re: [PATCH v4 6/9] Revert "USB: pci-quirks: Add Raspberry Pi 4 quirk" To: Nicolas Saenz Julienne Cc: Florian Fainelli , Greg Kroah-Hartman , Rob Herring , Stefan Wahren , Philipp Zabel , USB , Linux Kernel Mailing List , linux-rpi-kernel , linux-arm Mailing List , bcm-kernel-feedback-list , tim.gover@raspberrypi.org, linux-pci , Bjorn Helgaas , Mathias Nyman , Lorenzo Pieralisi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 6:11 PM Nicolas Saenz Julienne wrote: > On Mon, 2020-06-22 at 17:44 +0300, Andy Shevchenko wrote: > > On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne > > wrote: > > > This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc. > > > > > > The initialization of Raspberry Pi 4's USB chip is now handled through a > > > reset controller. No need to directly call the firmware routine trough a > > > > trough -> through. > > > > > pci quirk. > > > > pci -> PCI. > > > > Noted > > > ... > > > > > - > > > -#include > > > - > > > > Leave one blank line here. > > This being a revert, does it make sense to do so? If we are 100% strict about > it, the space should come from a separate patch. > > That said, if you insist I'll be happy to edit it. Even though, this revert depends on the previous patches, so, considered as a new patch. I leave this to the maintainer to choose the best approach (update themselves, request new version, ...). -- With Best Regards, Andy Shevchenko