From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Felipe Balbi <balbi@kernel.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface
Date: Wed, 10 Feb 2016 16:24:48 +0200 [thread overview]
Message-ID: <CAHp75VcuDpUtEKihpu1uAfkVKuf6eOjrt6Y4VwWE0wcYoN3ERQ@mail.gmail.com> (raw)
In-Reply-To: <1455113742.8878.14.camel@suse.com>
On Wed, Feb 10, 2016 at 4:15 PM, Oliver Neukum <oneukum@suse.com> wrote:
> On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote:
>> > +err:
>> > + if (i > 0)
>> > + for (; i >= 0; i--, con--)
>> > + typec_unregister_port(con->port);
>>
>> Perhaps
>>
>> while (--i >= 0) {
>> ...
>> }
>
> While we are at it. No we should not change the semantics
> of conditionals for the sake of appearance.
I'm sorry I didn't get you.
How this more or less standard pattern to clean up stuff on error path
does with conditional semantics?
I also noticed that this code might be factored out to helper which
will do same things (only number of loops is different) in both cases.
What did I miss?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2016-02-10 14:24 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 17:01 [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Heikki Krogerus
2016-02-09 17:01 ` [PATCH 1/3] usb: USB Type-C Connector Class Heikki Krogerus
2016-02-09 18:20 ` Greg KH
2016-02-10 10:38 ` Heikki Krogerus
2016-02-10 17:26 ` Greg KH
2016-02-11 14:07 ` Heikki Krogerus
2016-02-10 10:49 ` Oliver Neukum
2016-02-10 11:05 ` Andy Shevchenko
2016-02-10 11:11 ` Heikki Krogerus
2016-02-10 11:14 ` Andy Shevchenko
2016-02-10 11:23 ` Heikki Krogerus
2016-02-15 15:16 ` Oliver Neukum
2016-02-11 8:55 ` Felipe Balbi
2016-02-11 9:08 ` Oliver Neukum
2016-02-11 14:51 ` Heikki Krogerus
2016-02-11 14:36 ` Heikki Krogerus
2016-02-11 14:56 ` Oliver Neukum
2016-02-17 14:07 ` Oliver Neukum
2016-02-18 8:47 ` Heikki Krogerus
2016-02-18 9:21 ` Oliver Neukum
2016-02-18 13:09 ` Heikki Krogerus
2016-02-18 9:35 ` Oliver Neukum
2016-02-18 13:25 ` Heikki Krogerus
2016-02-18 13:44 ` Oliver Neukum
2016-02-18 15:13 ` Heikki Krogerus
2016-02-26 13:09 ` Heikki Krogerus
2016-02-09 17:01 ` [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus
2016-02-09 18:21 ` Greg KH
2016-02-10 10:30 ` Heikki Krogerus
2016-02-10 17:20 ` Greg KH
2016-02-11 13:50 ` Heikki Krogerus
2016-02-15 15:30 ` Oliver Neukum
2016-02-16 9:22 ` Heikki Krogerus
2016-02-16 13:39 ` Oliver Neukum
2016-02-17 7:58 ` Heikki Krogerus
2016-02-17 9:03 ` Oliver Neukum
2016-02-17 10:29 ` Felipe Balbi
2016-02-17 10:36 ` Oliver Neukum
2016-02-17 11:11 ` Heikki Krogerus
2016-02-17 13:36 ` Felipe Balbi
2016-02-17 14:28 ` Heikki Krogerus
2016-02-18 9:07 ` Peter Chen
2016-02-18 10:44 ` Heikki Krogerus
2016-02-18 10:37 ` Rajaram R
2016-02-18 10:47 ` Heikki Krogerus
2016-02-18 11:06 ` Rajaram R
2016-02-17 13:34 ` Felipe Balbi
2016-02-17 13:51 ` Oliver Neukum
2016-02-18 7:08 ` Felipe Balbi
2016-02-18 10:18 ` Oliver Neukum
2016-02-18 10:30 ` Felipe Balbi
2016-02-18 10:40 ` Oliver Neukum
2016-02-18 9:29 ` Peter Chen
2016-02-18 9:44 ` Oliver Neukum
2016-02-10 11:19 ` Oliver Neukum
2016-02-10 12:04 ` Heikki Krogerus
2016-02-10 11:56 ` Andy Shevchenko
2016-02-10 13:21 ` Oliver Neukum
2016-02-10 14:02 ` Andy Shevchenko
2016-02-10 15:11 ` Bjørn Mork
2016-02-11 8:26 ` Andy Shevchenko
2016-02-11 8:59 ` Bjørn Mork
2016-02-10 14:15 ` Oliver Neukum
2016-02-10 14:24 ` Andy Shevchenko [this message]
2016-02-10 15:08 ` Oliver Neukum
[not found] ` <CAHp75VfmGsskf7Cmni3b4=tCbkPsR8d3jPYiv93Lm6DM9gq1-g@mail.gmail.com>
2016-02-11 8:13 ` Fwd: " Andy Shevchenko
2016-02-11 14:10 ` Heikki Krogerus
2016-02-10 13:04 ` Oliver Neukum
2016-02-11 14:08 ` Heikki Krogerus
2016-02-09 17:01 ` [PATCH 3/3] usb: type-c: UCSI ACPI driver Heikki Krogerus
2016-02-09 18:22 ` Greg KH
2016-02-10 10:23 ` Heikki Krogerus
2016-02-17 18:53 ` [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Oliver Neukum
2016-02-18 9:21 ` Heikki Krogerus
2016-02-17 19:34 ` Rajaram R
2016-02-18 11:05 ` Heikki Krogerus
2016-02-18 11:15 ` Oliver Neukum
2016-05-05 3:05 ` Guenter Roeck
2016-05-06 6:50 ` Felipe Balbi
2016-05-06 8:05 ` Guenter Roeck
2016-05-06 8:29 ` Heikki Krogerus
2016-05-06 14:10 ` Guenter Roeck
2016-05-06 8:23 ` Heikki Krogerus
2016-05-06 8:08 ` Heikki Krogerus
2016-05-06 14:08 ` Guenter Roeck
2016-05-11 3:14 ` Guenter Roeck
2016-05-11 9:40 ` Heikki Krogerus
2016-05-11 14:47 ` Guenter Roeck
2016-05-13 14:23 ` Heikki Krogerus
2016-05-13 17:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcuDpUtEKihpu1uAfkVKuf6eOjrt6Y4VwWE0wcYoN3ERQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).