From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Andy Shevchenko <andy@infradead.org>,
Hans de Goede <hdegoede@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Darren Hart <dvhart@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] usb: roles: intel_xhci: Supplying software node for the role mux
Date: Fri, 16 Aug 2019 16:45:50 +0300 [thread overview]
Message-ID: <CAHp75VcuR+X5=-+VQ9HxU5Nh-uexzDbmZzX_JbZZ2B6tYXQmAQ@mail.gmail.com> (raw)
In-Reply-To: <20190816104515.63613-3-heikki.krogerus@linux.intel.com>
On Fri, Aug 16, 2019 at 1:45 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> The primary purpose for this node will be to allow linking
> the users of the switch to it. The users will be for example
> USB Type-C connectors. By supplying a reference to this
> node in the software nodes representing the USB Type-C
> controllers or connectors, the drivers for those devices can
> access the switch.
> + ret = software_node_register(&intel_xhci_usb_node);
> + if (ret)
> + return ret;
> +
> + sw_desc.set = intel_xhci_usb_set_role,
> + sw_desc.get = intel_xhci_usb_get_role,
> + sw_desc.allow_userspace_control = true,
> + sw_desc.fwnode = software_node_fwnode(&intel_xhci_usb_node);
> +
> data->role_sw = usb_role_switch_register(dev, &sw_desc);
> if (IS_ERR(data->role_sw))
> return PTR_ERR(data->role_sw);
Sounds to me like more fwnode_handle_put() calls are missed.
> @@ -164,6 +173,8 @@ static int intel_xhci_usb_remove(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
>
> usb_role_switch_unregister(data->role_sw);
> + fwnode_handle_put(software_node_fwnode(&intel_xhci_usb_node));
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-08-16 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 10:45 [PATCH v2 0/3] software node: Introduce software_node_find_by_name() Heikki Krogerus
2019-08-16 10:45 ` [PATCH v2 1/3] software node: Add software_node_find_by_name() Heikki Krogerus
2019-08-16 13:42 ` Andy Shevchenko
2019-08-16 10:45 ` [PATCH v2 2/3] usb: roles: intel_xhci: Supplying software node for the role mux Heikki Krogerus
2019-08-16 13:45 ` Andy Shevchenko [this message]
2019-08-16 13:52 ` Heikki Krogerus
2019-08-16 19:43 ` Hans de Goede
2019-08-16 10:45 ` [PATCH v2 3/3] platform/x86: intel_cht_int33fe: Use new API to gain access to the role switch Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcuR+X5=-+VQ9HxU5Nh-uexzDbmZzX_JbZZ2B6tYXQmAQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).