From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Martin Brandenburg <martin@omnibond.com>
Cc: Mike Marshall <hubcap@omnibond.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/3] orangefs: strncpy -> strlcpy
Date: Fri, 8 Apr 2016 19:02:54 +0300 [thread overview]
Message-ID: <CAHp75VczoOyAsQK=z9Q5riFnin56==vitLvJqGM-kDQA=XB3Gg@mail.gmail.com> (raw)
In-Reply-To: <alpine.BSO.2.20.1604081133500.7610@tp.mkb.name>
On Fri, Apr 8, 2016 at 6:34 PM, <martin@omnibond.com> wrote:
>> On Thu, Apr 7, 2016 at 2:39 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>> > On Mon, Apr 4, 2016 at 11:26 PM, Martin Brandenburg <martin@omnibond.com> wrote:
>> >> From: Martin Brandenburg <martin@omnibond.com>
>> >>
>> >> Almost everywhere we use strncpy we should use strlcpy. This affects
>> >> path names (d_name mostly), symlink targets, and server names.
>> >>
>> >> Leave debugfs code as is for now, though it could use a review as well.
>> >>
>> >
>> > |Why not strscpy() as most robust one?
>
> Mostly because I hadn't heard about strscpy.
It was nice story how he applied it to the tree.
>> It looks like strscpy went in last October... there are
>> no users of it yet. I was just about to send in a pull request
>> that includes Martin's strncpy->strlcpy patch when I saw
>> Andy's comment.
>>
>> Linus said when he pulled strscpy:
> After looking over strscpy I don't see a compelling
> reason not to go ahead and use it while we're fixing up
> this code.
I recommend to mention that this is a fix explicitly in the commit
message, currently it sounds like a meaningless patch of trainee.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2016-04-08 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 20:26 [PATCH 1/3] orangefs: clean up truncate ctime and mtime setting Martin Brandenburg
2016-04-04 20:26 ` [PATCH 2/3] orangefs: strncpy -> strlcpy Martin Brandenburg
2016-04-07 18:39 ` Andy Shevchenko
2016-04-07 19:43 ` Mike Marshall
2016-04-08 15:34 ` martin
2016-04-08 16:02 ` Andy Shevchenko [this message]
2016-04-08 17:16 ` martin
2016-04-08 17:33 ` [PATCH] orangefs: strncpy -> strscpy Martin Brandenburg
2016-04-04 20:26 ` [PATCH 3/3] orangefs: remove unused variable Martin Brandenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VczoOyAsQK=z9Q5riFnin56==vitLvJqGM-kDQA=XB3Gg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).