From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757144AbdE0OB7 (ORCPT ); Sat, 27 May 2017 10:01:59 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:35735 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752955AbdE0OB5 (ORCPT ); Sat, 27 May 2017 10:01:57 -0400 MIME-Version: 1.0 In-Reply-To: <1c56ad8f-2128-3fe2-7a22-fb2074084a5e@siemens.com> References: <20170526110454.1119-1-git@andred.net> <1c56ad8f-2128-3fe2-7a22-fb2074084a5e@siemens.com> From: Andy Shevchenko Date: Sat, 27 May 2017 17:01:56 +0300 Message-ID: Subject: Re: [PATCH] scripts/gdb: make lx-dmesg command work (reliably) To: Jan Kiszka Cc: =?UTF-8?Q?Andr=C3=A9_Draszik?= , "linux-kernel@vger.kernel.org" , Kieran Bingham Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4RE2DhT007510 On Fri, May 26, 2017 at 2:12 PM, Jan Kiszka wrote: > On 2017-05-26 13:04, André Draszik wrote: >> + log_buf_addr = int(str(gdb.parse_and_eval("'printk.c'::log_buf")).split()[0], 16) > > Overlong line. Please stay pep8 compliant. What I heard from colleague of mine couple of years ago, they (their team) moved to 100 characters in Python scripts because of somehow stupid recommendations from last century. -- With Best Regards, Andy Shevchenko