From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: Al Cooper <alcooperx@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
USB <linux-usb@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] usb: Make sync_all_pins static
Date: Fri, 30 Oct 2020 13:18:33 +0200 [thread overview]
Message-ID: <CAHp75Vd46nO9nXAZZ5-XKZR3_wq-o37MdmLNm_KUTSvhsq+whQ@mail.gmail.com> (raw)
In-Reply-To: <1604050097-91302-1-git-send-email-zou_wei@huawei.com>
On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@huawei.com> wrote:
The title can be more precise.
> Fix the following sparse warning:
>
> drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
Do we really need to know the path?
> The sync_all_pins has only call site within brcmstb-usb-pinmap.c
sync_all_pins()
> It should be static
Missed period.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-30 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 9:28 [PATCH -next] usb: Make sync_all_pins static Zou Wei
2020-10-30 11:18 ` Andy Shevchenko [this message]
2020-10-30 12:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd46nO9nXAZZ5-XKZR3_wq-o37MdmLNm_KUTSvhsq+whQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).