From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966932AbdADJXc (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 04:23:32 -0500
Received: from mail-qk0-f194.google.com ([209.85.220.194]:35548 "EHLO
        mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965404AbdADJX0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 04:23:26 -0500
MIME-Version: 1.0
In-Reply-To: <1483470276-10517-2-git-send-email-geert@linux-m68k.org>
References: <1483470276-10517-1-git-send-email-geert@linux-m68k.org> <1483470276-10517-2-git-send-email-geert@linux-m68k.org>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 4 Jan 2017 11:22:12 +0200
Message-ID: <CAHp75Vd6Y32BVPC13za0Lbmiiuju0oVkYU8tT1KHnOLxrqj7WQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] lib: Add module support to glob tests
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Matt Domsch <Matt_Domsch@dell.com>,
        Luca Barbieri <luca@luca-barbieri.com>,
        George Spelvin <linux@horizon.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 3, 2017 at 9:04 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Extract the glob test code into its own source file, to allow to
> compile it either to a loadable module, or builtin into the kernel.

To the whole series
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

One minor comment below.

> +obj-$(CONFIG_GLOB_SELFTEST) += globtest.o

Can we use pattern test_*, or at least *_test.*?

-- 
With Best Regards,
Andy Shevchenko