From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] kernel/SRCU: Fix ctags
Date: Mon, 29 Oct 2018 22:11:52 +0200 [thread overview]
Message-ID: <CAHp75Vd7XpPgx+RuOon6HD0U7LcKrqJLgukEk0wfYFrii=2DJg@mail.gmail.com> (raw)
In-Reply-To: <20181029200920.28901-1-semen.protsenko@linaro.org>
On Mon, Oct 29, 2018 at 10:09 PM Sam Protsenko
<semen.protsenko@linaro.org> wrote:
>
> ctags indexing ("make tags" command) throws this warning:
>
> ctags: Warning: include/linux/notifier.h:125:
> null expansion of name pattern "\1"
>
> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
> getting rid of line break.
>
> Similar fix was already done in commit 25528213fe9f ("tags: Fix
> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
Why not to add Fixes tag here as well?
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> include/linux/notifier.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
> index f35c7bf76143..0096a05395e3 100644
> --- a/include/linux/notifier.h
> +++ b/include/linux/notifier.h
> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
>
> #ifdef CONFIG_TREE_SRCU
> #define _SRCU_NOTIFIER_HEAD(name, mod) \
> - static DEFINE_PER_CPU(struct srcu_data, \
> - name##_head_srcu_data); \
> + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
> mod struct srcu_notifier_head name = \
> SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
>
> --
> 2.19.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-29 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 20:09 [PATCH v2] kernel/SRCU: Fix ctags Sam Protsenko
2018-10-29 20:11 ` Sam Protsenko
2018-10-30 6:34 ` Greg KH
2018-10-29 20:11 ` Andy Shevchenko [this message]
2018-10-30 19:31 ` Sam Protsenko
2018-10-30 20:28 Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd7XpPgx+RuOon6HD0U7LcKrqJLgukEk0wfYFrii=2DJg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).