From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C320CC63697 for ; Wed, 18 Nov 2020 09:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C030246B0 for ; Wed, 18 Nov 2020 09:56:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iH601Gg7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727521AbgKRJ4H (ORCPT ); Wed, 18 Nov 2020 04:56:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727043AbgKRJ4H (ORCPT ); Wed, 18 Nov 2020 04:56:07 -0500 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE023C0613D4; Wed, 18 Nov 2020 01:56:05 -0800 (PST) Received: by mail-pj1-x1042.google.com with SMTP id h12so780926pjv.2; Wed, 18 Nov 2020 01:56:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iN17+NL6h1ATpfyCdibmddqKJUozPpM85yOX+t7P07s=; b=iH601Gg7erHx4XMuGEchEuetzhu7G/RZ5OWbOS3W3/wzXOSJsmX0VTIax8BjL9m5uz GXQ3Js7foFc2XTpaTDPT3YqS7DQ2CzIhnXwQN7MRiheKtQc5DwMKeKKuz3qnGmlnbcla +3kvcBguWTTCeqyc9l+yoldR9X9PFhz4w7+wqEfluCVzevJxHfuWykfpTMFOcJzNDpVC 7VDtRtPCcjoutmpn0ruSU0o6anEAKcagv1kx0rgK3ptvJwtGIX6DNkLh1UbkvDazxf/n SfenlBosZtKaZ1+lT8+/fpV74scF7KMfLWXqVGoqafv6CfEeQlSteF8mDj8xx6qbiZog oZEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iN17+NL6h1ATpfyCdibmddqKJUozPpM85yOX+t7P07s=; b=WjIO/WMVHnNw9qz0Ied2W5+NJSVO/9kcqUj/1GqEt85ypXSR6bi5owIqtkh/+gsjlr p63PmIgzkEwozEbrFKiEn2l7A0nDMDnnMs9/N+HYq67TdNoGYCc2w0GUdt4oUcGxuXR2 yB+iHnLxeco/jF6lj6ZdrRQrNTawe121sHvTnjAxpxzvAPKUQzi9rVZcp4r9uFThxgpO mZwz/vpBCGbYpgjA1uVSNgLfgxPS7Vu+CHZBOiozzyfIZeFBb7rHRp+IU/x3SkrAdJaW DBXCsAi3MO8oU2JTkdFqCUW+8XORjhnuHuIZqe1NhYRcDYpNBR5NMaLTDPtypdNJfim/ 1/kg== X-Gm-Message-State: AOAM533zjdOrfpcZt2cXtvGLHqowSeZVAjO9+wSsf/jgiyM2u8pZ8NBL mvpOaCZeOwVL0OytAdW8kqY6D0PwERHmr6GIwSY= X-Google-Smtp-Source: ABdhPJwdxF1Zf/yjvQENLno08HERXXeTB9PR24kk98KO1SzJYVXr7enJkFxf3Vj9hg7d/FeAQooIGQGeN9ak0W7yBM0= X-Received: by 2002:a17:90a:d90a:: with SMTP id c10mr3343024pjv.129.1605693365044; Wed, 18 Nov 2020 01:56:05 -0800 (PST) MIME-Version: 1.0 References: <20201117154340.18216-1-info@metux.net> <20201118095342.sviuxvfsbmmn22mo@pengutronix.de> In-Reply-To: <20201118095342.sviuxvfsbmmn22mo@pengutronix.de> From: Andy Shevchenko Date: Wed, 18 Nov 2020 11:56:53 +0200 Message-ID: Subject: Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI_PTR() macros To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: "Enrico Weigelt, metux IT consult" , Jonathan Cameron , Linus Walleij , linux-tegra@vger.kernel.org, Thierry Reding , Alban Bedel , Manivannan Sadhasivam , Lee Jones , Florian Fainelli , Kevin Hilman , zhang.lyra@gmail.com, =?UTF-8?B?TWFyZWsgQmVow7pu?= , Bartosz Golaszewski , bcm-kernel-feedback-list , dl-linux-imx , orsonzhai@gmail.com, Eugeniy Paltsev , linux-pwm@vger.kernel.org, Grygorii Strashko , Philipp Zabel , Sascha Hauer , Vladimir Zapolskiy , "open list:GPIO SUBSYSTEM" , Fabio Estevam , Santosh Shilimkar , Matthias Brugger , Linux OMAP Mailing List , Hoan Tran , Scott Branden , Andrew Jeffery , Linux Kernel Mailing List , Serge Semin , Sascha Hauer , baolin.wang7@gmail.com, Shawn Guo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 18, 2020 at 11:54 AM Uwe Kleine-K=C3=B6nig wrote: > On Tue, Nov 17, 2020 at 06:45:37PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 17, 2020 at 5:45 PM Enrico Weigelt, metux IT consult > > wrote: > > > > > > The of_match_ptr(foo) macro evaluates to foo, only if > > > CONFIG_OF is set, otherwise to NULL. Same does ACPI_PTR with > > > CONFIG_ACPI. That's very helpful for drivers that can be used > > > with or without oftree / acpi. > > > > > > Even though most of the drivers touched here probably don't > > > actually need that, it's also nice for consistency to make it > > > the de-facto standard and change all drivers to use the > > > of_match_ptr() and ACPI_PTR() macros. > > > > > > A nice side effect: in some situations, when compiled w/o > > > CONFIG_OF/CONFIG_ACPI, the corresponding match tables could > > > automatically become unreferenced and optimized-away by the > > > compiler, w/o explicitly cluttering the code w/ ifdef's. > > > > NAK. > > > > It prevents using DT-enabled drivers on ACPI based platforms. > > So a system without CONFIG_OF might still make use of .of_match_table? Yep! > If so: TIL ... --=20 With Best Regards, Andy Shevchenko