From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbbCaHm5 (ORCPT ); Tue, 31 Mar 2015 03:42:57 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:33600 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbbCaHmz (ORCPT ); Tue, 31 Mar 2015 03:42:55 -0400 MIME-Version: 1.0 In-Reply-To: <5519EB1D.6070200@codeaurora.org> References: <1427741869-239562-1-git-send-email-andriy.shevchenko@linux.intel.com> <1427741869-239562-2-git-send-email-andriy.shevchenko@linux.intel.com> <5519EB1D.6070200@codeaurora.org> Date: Tue, 31 Mar 2015 10:42:53 +0300 Message-ID: Subject: Re: [PATCH v2 1/2] clk: fractional-divider: switch to rational best approximation From: Andy Shevchenko To: Stephen Boyd Cc: Andy Shevchenko , "linux-kernel@vger.kernel.org" , "Krogerus, Heikki" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 3:32 AM, Stephen Boyd wrote: > On 03/30/15 11:57, Andy Shevchenko wrote: >> This patch converts the code to use rational best approximation algorithm which >> is more precise. >> --- a/drivers/clk/Kconfig >> +++ b/drivers/clk/Kconfig >> @@ -14,6 +14,7 @@ config COMMON_CLK >> select HAVE_CLK_PREPARE >> select CLKDEV_LOOKUP >> select SRCU >> + select RATIONAL >> ---help--- >> The common clock framework is a single definition of struct >> clk, useful across many platforms, as well as an >> @@ -63,7 +64,6 @@ config COMMON_CLK_SI5351 >> tristate "Clock driver for SiLabs 5351A/B/C" >> depends on I2C >> select REGMAP_I2C >> - select RATIONAL >> ---help--- >> This driver supports Silicon Labs 5351A/B/C programmable clock >> generators. >> @@ -139,7 +139,6 @@ config COMMON_CLK_CDCE706 >> tristate "Clock driver for TI CDCE706 clock synthesizer" >> depends on I2C >> select REGMAP_I2C >> - select RATIONAL >> ---help--- >> This driver supports TI CDCE706 programmable 3-PLL clock synthesizer. > > Will some kernel janitor find us if we leave the selects here? I know > you removed it because COMMON_CLK must be Y here and we'd always select > RATIONAL, but it feels better to leave it alone and actually split off > the basic clock types into individual configs so that the tiny kernel > users don't have unused code lying around. That could be future work > someday and then we might forget to select RATIONAL again. I'm fine with that as well. So, do I need to resend or you apply modified version? -- With Best Regards, Andy Shevchenko