linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	ars@metafoo.de, Jonathan Cameron <jic23@kernel.org>,
	Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: Re: [PATCH v2] iio: core: fix double free in iio_device_unregister_sysfs()
Date: Tue, 12 Oct 2021 23:27:56 +0300	[thread overview]
Message-ID: <CAHp75VdAbhmd1UeFmyN1qPYOh-GKWmdStAC7WRSn91=UpDQ+Tw@mail.gmail.com> (raw)
In-Reply-To: <20211011092028.2310144-1-yangyingliang@huawei.com>

On Mon, Oct 11, 2021 at 12:12 PM Yang Yingliang
<yangyingliang@huawei.com> wrote:
>
> I got the double free report:
>
> BUG: KASAN: double-free or invalid-free in kfree+0xce/0x390
>
> CPU: 0 PID: 359 Comm: xrun Tainted: G        W         5.15.0-rc3-00109-g4dfd49fafc4d-dirty #474 523b7f3c65c42247635e2ac04a95f61f9f36678d
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014
> Call Trace:
>  dump_stack_lvl+0xe2/0x152
>  print_address_description.constprop.7+0x21/0x150
>  kasan_report_invalid_free+0x6f/0xa0
>  __kasan_slab_free+0x125/0x140
>  slab_free_freelist_hook+0x10d/0x240
>  kfree+0xce/0x390
>  iio_device_unregister_sysfs+0x108/0x13b [industrialio]
>  iio_dev_release+0x9e/0x10e [industrialio]
>  device_release+0xa5/0x240
>  kobject_put+0x1e5/0x540
>  put_device+0x20/0x30
>  devm_iio_device_release+0x21/0x30 [industrialio]
>  release_nodes+0xc3/0x3b0
>  devres_release_group+0x1da/0x2c0
>  i2c_device_probe+0x628/0xbb0
>  really_probe+0x285/0xc30

Please, reduce this noise to the ~4-5 important lines only!

-- 
With Best Regards,
Andy Shevchenko

      reply	other threads:[~2021-10-12 17:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11  9:20 [PATCH v2] iio: core: fix double free in iio_device_unregister_sysfs() Yang Yingliang
2021-10-12 20:27 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VdAbhmd1UeFmyN1qPYOh-GKWmdStAC7WRSn91=UpDQ+Tw@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=ars@metafoo.de \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).