From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Denis Ciocca <denis.ciocca@st.com>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
grygorii.tertychnyi@leica-geosystems.com,
andrey.zhizhikin@leica-geosystems.com,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Subject: Re: [PATCH 2/2] iio:magnetometer: Support for ST magnetic sensors
Date: Tue, 9 Mar 2021 13:01:03 +0200 [thread overview]
Message-ID: <CAHp75VdBRtpkA5zmpEZ+gdP=RwYaoTsyDBqvvO2w67T6-6kqMw@mail.gmail.com> (raw)
In-Reply-To: <20210306164217.2d8166da@archlinux>
On Sat, Mar 6, 2021 at 6:44 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Fri, 5 Mar 2021 07:05:36 +0000
> LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> wrote:
>
> > Add support for STMicroelectronics digital magnetic sensors,
> > LSM303AH,LSM303AGR,LIS2MDL,ISM303DAC,IIS2MDC.
> >
> > The patch tested with IIS2MDC instrument.
> >
> > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
>
> Hi,
>
> Given that at least two parts in here is supported by the existing
> driver in
> iio/magnetometers/st_magn_*.c (lsm303agr) can you confirm that it
> doesn't make sense to simply extend that driver to support the
> other parts? This is particularly true when the WHO AM I register
> reads 0x40 for all these parts.
>
> I've done a fairly superficial review whilst here, but please check
> you can't just add the relevant entries to the existing driver.
I even hadn't looked into the code because this one needs a very good
justification why it's a new driver rather than extension of the
existing one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-09 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 7:05 [PATCH 1/2] dt-bindings: iio: st,st-sensors.yaml New iis2mdc bindings LI Qingwu
2021-03-05 7:05 ` [PATCH 2/2] iio:magnetometer: Support for ST magnetic sensors LI Qingwu
2021-03-06 16:42 ` Jonathan Cameron
2021-03-09 5:56 ` LI Qingwu
2021-03-09 11:01 ` Andy Shevchenko [this message]
2021-03-11 7:46 ` LI Qingwu
2021-03-08 21:55 ` [PATCH 1/2] dt-bindings: iio: st,st-sensors.yaml New iis2mdc bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdBRtpkA5zmpEZ+gdP=RwYaoTsyDBqvvO2w67T6-6kqMw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Qing-wu.Li@leica-geosystems.com.cn \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.tertychnyi@leica-geosystems.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).