From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FD9C433E3 for ; Thu, 27 Aug 2020 09:19:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 665A32177B for ; Thu, 27 Aug 2020 09:19:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CxWG48zp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728455AbgH0JTE (ORCPT ); Thu, 27 Aug 2020 05:19:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727897AbgH0JTC (ORCPT ); Thu, 27 Aug 2020 05:19:02 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4093C061264; Thu, 27 Aug 2020 02:19:02 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id y206so3014880pfb.10; Thu, 27 Aug 2020 02:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VgFZ3oc2fxtal1v8qY7ILD3Hbp8X8hErMNMpovFOacY=; b=CxWG48zpulIoeeq4DDcQ2DoH/7wm4cQm+Pj/r8BEZ6iyyW6Ib0Kc5jYbCyKqmWsynR D92g1UgE5FRMcGm9T1RA696WTtsk9alwjRfwS3P9R41UmTmNkVzLT6S+3iYVtmh6W7zf bH0UbQTeOH/bfOp+75Og0cffB8MayR3NU30CIWEgYBqDjYESVMPEzBOInc/A+GVS1H5M +HdLV5FObiPvtHL6X3W+dKYaJacFoPdDAQez42wmzladeuJqfB1vTCvRUMiAfbYAyeaH t0/ouM+Q3G6x0RyAHZPwRUbruCLmcfLFFCAi6SduqDpl/KiFG2u6W8QPFNQV4jcR0zNF 9dcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VgFZ3oc2fxtal1v8qY7ILD3Hbp8X8hErMNMpovFOacY=; b=YReUTxTFhEFhhneajqkno3kKB3n4e0Ba0+TBB7IEtkVkIUwHm+LkzQXIPK9wnyxNdG azx93/dqwz3TKia4d5BW73ncYgjzYZInqp2wOiE+NkKRMewNvNjMEbWL0W+WuC264/Zw IFZtDwDdDslyI/FdZjWttUj1GhaXJKToaQlEQQDNcdbIiKV483e5JvRbI21Wubk5I+1y sPAcvuDOHaZ3kdUp7kvbe5GQctZvuKss9bRMhJPkUj5mRpoALPiw8QNJ5tK6JqAf/SAE Pn1xnYmS/QCn5FHK44LP15JMPWIHntdS4yvefaOXYRX1GCMY9MZRaXVjNMAtjANajpIq JrJw== X-Gm-Message-State: AOAM532CCakWHC7I3d0gZnvfv1rHkudxrYcNgT1cbtq8M02Z1spFRXCU O2XdR5gE3kB+aPSa6W1cglipKPCt/fuyCxnml38= X-Google-Smtp-Source: ABdhPJy2sx0lGOZtzgnh0B94nDuzu7sanQKqJ7UK1Q4rptGZJnV9/hL7Za1e1VRKnFZKTXqmiZmX63dTU7SojC/8zTg= X-Received: by 2002:a62:9215:: with SMTP id o21mr4726022pfd.268.1598519942162; Thu, 27 Aug 2020 02:19:02 -0700 (PDT) MIME-Version: 1.0 References: <20200826181706.11098-1-krzk@kernel.org> <20200826181706.11098-23-krzk@kernel.org> In-Reply-To: <20200826181706.11098-23-krzk@kernel.org> From: Andy Shevchenko Date: Thu, 27 Aug 2020 12:18:46 +0300 Message-ID: Subject: Re: [PATCH 23/24] Input: surface3_spi - Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , "Gustavo A. R. Silva" , Andy Shevchenko , linux-input , Linux Kernel Mailing List , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 9:22 PM Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. Reviewed-by: Andy Shevchenko > Signed-off-by: Krzysztof Kozlowski > --- > drivers/input/touchscreen/surface3_spi.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c > index ce4828b1415a..25bb77ddf2ef 100644 > --- a/drivers/input/touchscreen/surface3_spi.c > +++ b/drivers/input/touchscreen/surface3_spi.c > @@ -223,7 +223,6 @@ static void surface3_spi_power(struct surface3_ts_data *data, bool on) > */ > static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) > { > - int error; > struct device *dev; > struct gpio_desc *gpiod; > int i; > @@ -233,15 +232,9 @@ static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) > /* Get the reset lines GPIO pin number */ > for (i = 0; i < 2; i++) { > gpiod = devm_gpiod_get_index(dev, NULL, i, GPIOD_OUT_LOW); > - if (IS_ERR(gpiod)) { > - error = PTR_ERR(gpiod); > - if (error != -EPROBE_DEFER) > - dev_err(dev, > - "Failed to get power GPIO %d: %d\n", > - i, > - error); > - return error; > - } > + if (IS_ERR(gpiod)) > + return dev_err_probe(dev, PTR_ERR(gpiod), > + "Failed to get power GPIO %d\n", i); > > data->gpiod_rst[i] = gpiod; > } > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko