From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hein Tibosch <hein_tibosch@yahoo.es>
Cc: Andrew Morton <akpm@linux-foundation.org>,
viresh kumar <viresh.kumar@linaro.org>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
"ludovic.desroches" <ludovic.desroches@atmel.com>,
Havard Skinnemoen <havard@skinnemoen.net>,
spear-devel <spear-devel@list.st.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] avr32: at32ap700x: set DMA slave properties for MCI dw_dmac
Date: Mon, 3 Sep 2012 11:28:42 +0300 [thread overview]
Message-ID: <CAHp75VdLkUZraD5AR5zT32Fs+Eh9vC+DT1BE3Ebd_QASAX+jEQ@mail.gmail.com> (raw)
In-Reply-To: <50439D65.4010708@yahoo.es>
On Sun, Sep 2, 2012 at 8:54 PM, Hein Tibosch <hein_tibosch@yahoo.es> wrote:
> --- a/arch/avr32/mach-at32ap/at32ap700x.c
> +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> @@ -1355,6 +1355,10 @@ at32_add_device_mci(unsigned int id, struct mci_platform_data *data)
> | DWC_CFGH_DST_PER(1));
> slave->sdata.cfg_lo &= ~(DWC_CFGL_HS_DST_POL
> | DWC_CFGL_HS_SRC_POL);
> + /* Setup DMA controller: let source be master */
> + slave->sdata.src_master = 1;
I don't know the details, but do you want to set up dst_master as well?
> + /* Limit maximum transfer width to 32-bit */
> + slave->sdata.max_mem_width = DW_MEM_WIDTH_32;
It's under question regarding to my comments on previous patch.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2012-09-03 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 17:54 [PATCH v4 3/3] avr32: at32ap700x: set DMA slave properties for MCI dw_dmac Hein Tibosch
2012-09-03 8:28 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdLkUZraD5AR5zT32Fs+Eh9vC+DT1BE3Ebd_QASAX+jEQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd.bergmann@linaro.org \
--cc=egtvedt@samfundet.no \
--cc=havard@skinnemoen.net \
--cc=hein_tibosch@yahoo.es \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).