From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756093AbdKCMhV (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 08:37:21 -0400
Received: from mail-qt0-f182.google.com ([209.85.216.182]:54280 "EHLO
        mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750826AbdKCMhS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 08:37:18 -0400
X-Google-Smtp-Source: ABhQp+T/1shez4gtFk2SwpdbJrvkPWI1WXILj7H6qSoPl/Nj03MKGbcWIcr23GhpRGPmIANjOXhnvfU1O8/MeSJzpOs=
MIME-Version: 1.0
In-Reply-To: <20171031184123.ssv5yolajiv7u7gj@pali>
References: <20171031110318.20985-1-colin.king@canonical.com>
 <CAHp75Vec3Hjd_keMid-x6ub5ZJqUmq1nUFiHPsxuWt8V+vzrnQ@mail.gmail.com>
 <20171031135548.u5vtsxj7hbnuioz3@pali> <CAHp75VfAzk4n1HQETp+r5KGE5B_HmQ0JcsOwesvowuvt=wju5g@mail.gmail.com>
 <20171031141351.yrjhwweubwxptb4j@pali> <CAHp75Ve852xEsng4cCxznGpkt+P0pnCTX1k9qmVkkZPU3FskOA@mail.gmail.com>
 <20171031184123.ssv5yolajiv7u7gj@pali>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 3 Nov 2017 14:37:16 +0200
Message-ID: <CAHp75VdLwN2p5grNY--VzuPOp64aS70uqWdmPWA2-63We+yP_Q@mail.gmail.com>
Subject: Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments
 to byte_data
To: =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA3CbPgU007007

On Tue, Oct 31, 2017 at 8:41 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Tuesday 31 October 2017 20:08:45 Andy Shevchenko wrote:
>> On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
>> > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote:
>> >> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
>> >> > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote:
>> >> >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King <colin.king@canonical.com> wrote:
>>
>> >> OK, though it doesn't clarify the intention of the byte_data
>> >> (useless?) assignments.
>> >
>> > Probably similar code pattern exists in that lis3lv* driver...
>>
>> So, it seems to me OK to apply the patch. No objections?
>
> No objections, you can add my:
>
> Acked-by: Pali Rohár <pali.rohar@gmail.com>

Applied to my review and testing queue, thanks!

>
> --
> Pali Rohár
> pali.rohar@gmail.com



-- 
With Best Regards,
Andy Shevchenko