From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1CEC433DF for ; Tue, 30 Jun 2020 09:54:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A5A420675 for ; Tue, 30 Jun 2020 09:54:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iOZTw5p3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731583AbgF3Jx5 (ORCPT ); Tue, 30 Jun 2020 05:53:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbgF3Jx4 (ORCPT ); Tue, 30 Jun 2020 05:53:56 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45062C061755; Tue, 30 Jun 2020 02:53:56 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id e8so9721886pgc.5; Tue, 30 Jun 2020 02:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pu+8c4pxZP7VDPcWMX3cvDqtPoM2Z/4+ORSQBZa9fP8=; b=iOZTw5p3PhrLlB33oX3iHhPUa7AtOUAPU4fvtIi61vf7UYm4i+g1ybpyU0fH6irrMM wr/HuNGd0XsNfcKV+dxU90wRk/Zp6TC81oWimDnGh1DHx/WD+EG9VpnKOqWe4a6nSB4P CHGg/xLxDxTZ7ruZdr3kZNElBjD7Q58olV9nDKEArc/jJSdfa/GQ24jduQIdBSH/60pb k4zLDdY/ZG925UKIPnx3XklzXTanzkM/ZK70pASTgju0rAdzkrRoSeF1BPhWN9lSPKdb Bl1HiMs72X7BPylrygLupbmuXou6Tt0haGCEeljJZJiig+gyS9rvkvpvwVfnzjK2mb5s nWFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pu+8c4pxZP7VDPcWMX3cvDqtPoM2Z/4+ORSQBZa9fP8=; b=K9FbcUp9/9k6LrmN4jmAquxnif9ZpupnISVFmwZpfSEWiU+fpVR8zTnTDGKBQX1BCt npDMjeiyKiIYuSRaF8xuUyoXMBaTLD98lLX7RRDnb+EWSTnlyTM9BjnRRJwpyWb9NLEv MDNG1+Rj+T1zkaN+lE3mlIdRSdiodZx5Iq7ZynlkeKlIDmNPRuZYfKwa6n4i0Vj4RlLC RwASo+cHn7daNsKObamwuRAMSLNON6bo8q9x5TqEdY5zTs956Y+GZSdAcmdXm4B9TYaF 6//K+Rnl1/cXh9EA4R6VdUSON84p9X/786KSosn3ftiEbHV7gjz3Ingohm+TlKA0EoK1 E8XA== X-Gm-Message-State: AOAM533Y/vJBB8UD1US0p2GeLxL/HXVBD8N+kwpmICrI788uI+wiQ7Us utuW/w4hsTBx7aUvCM+KcHHE7M/TsgdtIl62ktQ= X-Google-Smtp-Source: ABdhPJzlE4kn4dGUwstGhu5m4jND3oHLT5GOH9/tz0SCDE/5Gq8P4XHxl8f6dclTHmHCeJcHoxAKreSrwL9AqmUTKKE= X-Received: by 2002:a63:ff52:: with SMTP id s18mr14592506pgk.203.1593510835663; Tue, 30 Jun 2020 02:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20200625075805.363918-1-mans0n@gorani.run> In-Reply-To: From: Andy Shevchenko Date: Tue, 30 Jun 2020 12:53:42 +0300 Message-ID: Subject: Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570 To: Bartosz Golaszewski Cc: Sungbo Eo , Linus Walleij , LKML , linux-gpio Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2020 at 12:28 PM Bartosz Golaszewski wrote: > On Thu, Jun 25, 2020 at 9:58 AM Sungbo Eo wrote: > > +static const struct of_device_id pca9570_of_match_table[] = { > > + { .compatible = "nxp,pca9570" }, > > + { /* sentinel */ } > > +}; > > +MODULE_DEVICE_TABLE(of, pca9570_of_match_table); > > If you're not using it in probe than maybe move it next to the I2C device table? (Side note) ...and even if so it can be assessed via a struct device pointer: dev->driver->id_table (don't remember by heart, but you have an idea). -- With Best Regards, Andy Shevchenko