From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7ACC6786F for ; Thu, 1 Nov 2018 13:44:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6619A20820 for ; Thu, 1 Nov 2018 13:44:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cg65fHXU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6619A20820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728917AbeKAWrs (ORCPT ); Thu, 1 Nov 2018 18:47:48 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:34765 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728676AbeKAWrr (ORCPT ); Thu, 1 Nov 2018 18:47:47 -0400 Received: by mail-qt1-f195.google.com with SMTP id z2-v6so21127853qts.1; Thu, 01 Nov 2018 06:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ngu/6E/81xEgZ53nEjR7sFfaI9G7qz85ekQLhGPWI/o=; b=cg65fHXUy0RykEeLxkh1WtzH3yc9v39R6sNiy9ehgkNN6KtTNBy2WyGWBimjwq+V17 kGZjS1PxUR1LDxPaxizB2j7wmk2QShHS3RESLkJeKHPnnY2eDUTbC4xtJ9kpJhk3S30+ S3JCji5qqcoP4oKQqZDkhmFiCWJ1o2CHGnj08Iprdx9JNDin3d2SqQM/YV7+8mWLAz5Q vV5QIfZHUDNMbxAmKnu/UpAXfzzZ8UoitjVqlM4I349RnAjCsTxGlI/NN9eHdSdD7zxq Nr5zZafYn2MDbqEPmePIgFmeF4O34aENJpDWb6FzZyr/dvitM0nao76hrSS5QH1079y0 7cxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ngu/6E/81xEgZ53nEjR7sFfaI9G7qz85ekQLhGPWI/o=; b=YpCZkN9RFb11maG0ybayfKfxl9ljOUv54rlk5B/YbGOmHgpeEvCOPZgWiuWpbMxWXn GZEquEti2cAGvDeFifZLBWitIHRvkJVJTRFidF7sYYDPKaL2BOwDo1vhsEPC2XJi9MqO 6scgkJAUxJbTM3BPYn0GNySbu19vvRrZ9sclC9RsuNX9EDzoXSOW0jbW8Ev0XlLChOD4 sVBdBodhJOy4dN+rrQhRmuzwC1iTwh6DaBj51p1d9Hjg7lIzKgwgT3K9H8Mqp2FliVxC B751c9cIJpQHvAy1gncOwLwtMkXbSzcLI2lzGGHOAw0ZyjBonHOJMy9XyUUmI8lmxcNs JKfA== X-Gm-Message-State: AGRZ1gI5edyVdhSMX5WF4Fa79hArKv4PAvvGW51Ap1WYymeELdTP/XM8 eBN4Z/+p7Ox5wadyC2vdgaknmrdtjIqmI1TAfbA= X-Google-Smtp-Source: AJdET5fhIj6qjhKGtfMk532eeo8iJK7JTgBpQrag4Ox/GNh7c++ftZvH4QuKQB71yA3GGYyY96ZdP9mChhOMd7jtdng= X-Received: by 2002:ac8:2413:: with SMTP id c19-v6mr6596843qtc.194.1541079884536; Thu, 01 Nov 2018 06:44:44 -0700 (PDT) MIME-Version: 1.0 References: <1541085002-42993-1-git-send-email-peng.hao2@zte.com.cn> <1541085002-42993-5-git-send-email-peng.hao2@zte.com.cn> In-Reply-To: <1541085002-42993-5-git-send-email-peng.hao2@zte.com.cn> From: Andy Shevchenko Date: Thu, 1 Nov 2018 15:44:33 +0200 Message-ID: Subject: Re: [PATCH V5 5/8] misc/pvpanic: simplify the code using acpi_dev_resource_io To: peng.hao2@zte.com.cn Cc: Rob Herring , Mark Rutland , Arnd Bergmann , Greg Kroah-Hartman , Andy Shevchenko , Darren Hart , Linux Kernel Mailing List , Platform Driver , hutao@cn.fujitsu.com, Linux Documentation List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote: > > use acpi_dev_resource_io API. > Same comments as per patch 1. This should be patch 2/8 in the series. Otherwise, Reviewed-by: Andy Shevchenko Also, you might consider to use Suggested-by tag here. > Signed-off-by: Peng Hao > --- > drivers/misc/pvpanic.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c > index 0bcf1cd..c20fdff 100644 > --- a/drivers/misc/pvpanic.c > +++ b/drivers/misc/pvpanic.c > @@ -64,17 +64,15 @@ > static acpi_status > pvpanic_walk_resources(struct acpi_resource *res, void *context) > { > - switch (res->type) { > - case ACPI_RESOURCE_TYPE_END_TAG: > - return AE_OK; > + struct resource r; > > - case ACPI_RESOURCE_TYPE_IO: > - port = res->data.io.minimum; > + if (acpi_dev_resource_io(res, &r)) { > + port = r.start; > return AE_OK; > - > - default: > - return AE_ERROR; > } > + > + return AE_ERROR; > + > } > > static int pvpanic_add(struct acpi_device *device) > -- > 1.8.3.1 > -- With Best Regards, Andy Shevchenko