From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752085AbdFSUrX (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Jun 2017 16:47:23 -0400
Received: from mail-qt0-f171.google.com ([209.85.216.171]:32931 "EHLO
        mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752132AbdFSUrV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Jun 2017 16:47:21 -0400
MIME-Version: 1.0
In-Reply-To: <1497904378-4808-1-git-send-email-sudipm.mukherjee@gmail.com>
References: <1497904378-4808-1-git-send-email-sudipm.mukherjee@gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 19 Jun 2017 23:47:20 +0300
Message-ID: <CAHp75VdQ0BoKtbr5m--sZH1yHs=Oo-B577VnxoO8E-0jn0QzCA@mail.gmail.com>
Subject: Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:


> +#ifdef CONFIG_X86
> +       primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> +                                       IORESOURCE_ROM_SHADOW;
> +#endif

Why do we need #ifdef?

In any case you may introduce a temporary variable to have pointer to resource

struct resource *res = &pdev->resource[PCI_ROM_RESOURCE];

-- 
With Best Regards,
Andy Shevchenko