From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A586C43462 for ; Mon, 17 May 2021 08:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CEBA610A0 for ; Mon, 17 May 2021 08:14:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235068AbhEQIP1 (ORCPT ); Mon, 17 May 2021 04:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230507AbhEQIP0 (ORCPT ); Mon, 17 May 2021 04:15:26 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E4EC061573; Mon, 17 May 2021 01:14:10 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id a11so2699145plh.3; Mon, 17 May 2021 01:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4RsJHAkXM13g+/qrHRXPZI6LQum424LLJFzHPADOTkg=; b=ijdufWDWPGznD7QEMu3dOT+uzMupZ0bWeJoCCehjcbjWi5nZ8sEjO/238STVhDt/VA nlIIS6alNXavim6RtzW/ULyvmEYcTFZ728Ig0dA3f+zFGKS1B2YlT0HiTAK3iCjEYbhE Pcn9mxqBqbv7cTXorHb0AGPoV2nkUsWqe9U8N4WUXn9WUNkv2P7hwfSPIC5cRhBqYETO VIrKYlJyjpLgF7mGvPzU99DB4Ccw/z9i6QOitrrTKJWp8ffwwlJpn0NDwJyYYgWpIwUp nrhVcA0dshY1GTxmWx06wDwhgIc4v2cDtLFqF1r3KHQpfWT63k+ReawdqpMJP3ZlBTMU zofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4RsJHAkXM13g+/qrHRXPZI6LQum424LLJFzHPADOTkg=; b=aaiIEAPMvD2gFmmm5PKJ9PTdHAC28bibePPmtjYGU5FNM2bvAShq+FZpnO0J8KaUOQ NKOQQCPvx/iz5HeC1gElT7bYtKd3SuvhNNUCDt9ywaHBDltX9oTd4SPtODUnqQckC0m+ 560v/NU73rSpr17Tu859VAOxsDY0Ga28xgyu5EWyGZCFwK/+IOdoZ0ONeMD08YfbEWvT 8pgXFKEqqTFsCofxY2LdEofEQDhnfJzFTdZKd14Xz2Pm/DK46baamvYnjTya/eSGxgI5 TWNxH9k7sGPBUkjGhEhtvSJutMfwJx6VuyD3+66Fnf3lgOmBq+UBl74/dvz34ElSRQpD YPDA== X-Gm-Message-State: AOAM530B7s3CVjA4/dubzhW0SaiKtp28G+a/5A5w4s2p4NoozHeVD/IL b2r9kid7JbFUASWPDZU9xhskHKAB8vYI50XQ/G8MbEMQFfI= X-Google-Smtp-Source: ABdhPJwfykSolhqvWJ+YlKXhqn13Qc5iEjFXiZuhIO/gwNJuDK8GoDS8r31itW8qiQuCa4uObrLYpwbmPoUsLqXpxz4= X-Received: by 2002:a17:90a:6c23:: with SMTP id x32mr30526126pjj.228.1621239249794; Mon, 17 May 2021 01:14:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andy Shevchenko Date: Mon, 17 May 2021 11:13:53 +0300 Message-ID: Subject: Re: [PATCH 0/5] RTL8231 GPIO expander support To: Sander Vanheule Cc: Pavel Machek , Rob Herring , Lee Jones , Linus Walleij , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 12:40 AM Sander Vanheule wrote: > On Wed, 2021-05-12 at 18:29 +0300, Andy Shevchenko wrote: > > On Tuesday, May 11, 2021, Sander Vanheule wrote: ... > > I have several comments to the series, but I may give them next week. > > > > Just couple here: > > 1. If subsystem provides a regmap API I would suggest to use it, I.o.w. try > > again to understand what is wrong with MDIO case. > > Are you referring to the MDIO regmap interface, or the GPIO regmap interface? MDIO > For the MDIO regmap interface, I have been able to resolve the Kconfig > dependency issue. So I can reintroduce that, if that's preferred over the > solution in this v1. > > With an extra patch, I was able to use the gpio-regmap interface, dropping most > of the GPIO code. The current gpio-regmap implementation makes the assumption > that an output value can be set while a pin is configured as an input. That > assumption is invalid for this chip, so I had to provide an extra flag for > gpio_regmap_config, similar to how this is handled in gpio-mmio. > > > > 2. Please, switch to fwnode API in LED driver > > Since you had the same comment on my previous patch set, I had already tried to > this this into account as much as possible. > > There's a few things I couldn't find the fwnode-equivalent for: > * I use of_node_name_prefix to enforce the naming required by the binding. I > could just walk over all (available) child nodes, which would be mostly > equivalent. AFAIU the LED traditional bindings is that you define LED compatible nodes and all child nodes of it are the one-per-LED ones, there shouldn't be others. > * To get the address of an LED child node, I use of_get_address, since this > appeared to provide what I want to do: get the address of the node. I know > next to nothing about ACPI. Does the equivalent exist there? Or am I taking > the wrong approach? What are the means of an address in this case? > I have updated patches ready, if you would rather just review a v2. -- With Best Regards, Andy Shevchenko